Correct os != "windows" constraints
#28805
Merged
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 31, 2025
|
There are lots of Windows CI failures 🤷 |
|
The windows CI failures are expected IIRC, c.f., #28706 for instance |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
oshaving valid values such as "linux", "macos", "freebsd", ... it is natural to expect that "windows" is also a valid value. It isn't unfortunately: https://github.com/ocaml/opam-repository/wiki/Depexts-os-distribution---os-family-values 😬This prompted me to see if there were occurrences of this test in the repo's constraints, and indeed I found a couple:
This PR fixes them to use the more common
os-family != "windows"instead (rather thanos != "win32").