Action fails after the recent release

[Saviq]

##[debug]Evaluating condition for step: 'Set up OCaml'
##[debug]Evaluating: success()
##[debug]Evaluating success:
##[debug]=> true
##[debug]Result: true
##[debug]Starting: Set up OCaml
##[debug]Loading inputs
##[debug]Evaluating: env.OPAM_COMP
##[debug]Evaluating Index:
##[debug]..Evaluating env:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'OPAM_COMP'
##[debug]=> '4.11.1'
##[debug]Result: '4.11.1'
##[debug]Loading env
Run avsm/setup-ocaml@v1
  with:
    ocaml-version: 4.11.1
  env:
    HEAD_REF: ci572279844
    RUN_URL: https://github.com/canonical/multipass-private/actions/runs/572279844
    BUILD_DIR: ../build
    MACOSX_DEPLOYMENT_TARGET: 10.14
    OPAM_COMP: 4.11.1
    OPAMVERBOSE: 1
    OPAMYES: 1
    HOMEBREW_NO_AUTO_UPDATE: 1
    QT_VERSION: 5.12.10
    PKG_CONFIG_PATH: /Users/cibot/actions-runner/_work/multipass-private/Qt/5.12.10/clang_64/lib/pkgconfig
    Qt5_Dir: /Users/cibot/actions-runner/_work/multipass-private/Qt/5.12.10/clang_64
    Qt5_DIR: /Users/cibot/actions-runner/_work/multipass-private/Qt/5.12.10/clang_64
    QT_PLUGIN_PATH: /Users/cibot/actions-runner/_work/multipass-private/Qt/5.12.10/clang_64/plugins
    QML2_IMPORT_PATH: /Users/cibot/actions-runner/_work/multipass-private/Qt/5.12.10/clang_64/qml
/usr/local/bin/brew install opam
Warning: opam 2.0.8 is already installed and up-to-date.
To reinstall 2.0.8, run:
  brew reinstall opam
/usr/local/bin/opam init --bare -yav https://github.com/ocaml/opam-repository.git

User configuration:
  ~/.bash_profile is already up-to-date.
[NOTE] Make sure that ~/.bash_profile is well sourced in your ~/.bashrc.

/Users/cibot/actions-runner/_work/_actions/avsm/setup-ocaml/v1/dist/install-ocaml-unix.sh 4.11.1
++ opam info -f version ocaml --color=never
+ CURRENT_OCAML=4.11.1
+ '[' 4.11.1 '!=' 4.11.1 ']'
+ opam switch set 4.11.1
Error: Error: The process '/Users/cibot/actions-runner/_work/_actions/avsm/setup-ocaml/v1/dist/install-ocaml-unix.sh' failed with exit code 5
##[debug]Node Action run completed with exit code 1
##[debug]OPAMJOBS='4'
##[debug]OPAMYES='1'
##[debug]Finishing: Set up OCaml

[Saviq]

On the host:

$ opam switch set 4.11.1
[ERROR] No switch 4.11.1 is currently installed. Did you mean 'opam switch create 4.11.1'?
        Installed switches are:
          - default

[smorimoto]

I'm sure it's already fixed in 1.1.8. The v1 tag has moved as well, so could you try to trigger the build again?

[Saviq]

Nope, this is with the latest v1:

Download action repository 'avsm/setup-ocaml@v1'
##[debug]Download 'https://api.github.com/repos/avsm/setup-ocaml/tarball/a5bec5f318993d00247f50f72d0ce9fbc2513c8a' to '/Users/cibot/actions-runner/_work/_actions/_temp_d1183935-9688-418c-8e7f-ec2308be20cb/584290d2-5402-46ba-9e53-564cf3221b7f.tar.gz'
##[debug]Unwrap 'avsm-setup-ocaml-a5bec5f' to '/Users/cibot/actions-runner/_work/_actions/avsm/setup-ocaml/v1'
##[debug]Archive '/Users/cibot/actions-runner/_work/_actions/_temp_d1183935-9688-418c-8e7f-ec2308be20cb/584290d2-5402-46ba-9e53-564cf3221b7f.tar.gz' has been unzipped into '/Users/cibot/actions-runner/_work/_actions/avsm/setup-ocaml/v1'.
...
##[debug]Evaluating condition for step: 'Set up OCaml'
##[debug]Evaluating: success()
##[debug]Evaluating success:
##[debug]=> true
##[debug]Result: true
##[debug]Starting: Set up OCaml
##[debug]Loading inputs
##[debug]Evaluating: env.OPAM_COMP
##[debug]Evaluating Index:
##[debug]..Evaluating env:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'OPAM_COMP'
##[debug]=> '4.11.1'
##[debug]Result: '4.11.1'
##[debug]Loading env
Run avsm/setup-ocaml@v1
/usr/local/bin/brew install opam
Warning: opam 2.0.8 is already installed and up-to-date.
To reinstall 2.0.8, run:
  brew reinstall opam
/usr/local/bin/opam init --bare -yav https://github.com/ocaml/opam-repository.git

User configuration:
  ~/.bash_profile is already up-to-date.
[NOTE] Make sure that ~/.bash_profile is well sourced in your ~/.bashrc.

/Users/cibot/actions-runner/_work/_actions/avsm/setup-ocaml/v1/dist/install-ocaml-unix.sh 4.11.1
++ opam info -f version ocaml --color=never
+ CURRENT_OCAML=4.11.1
+ '[' 4.11.1 '!=' 4.11.1 ']'
+ opam switch set 4.11.1
Error: Error: The process '/Users/cibot/actions-runner/_work/_actions/avsm/setup-ocaml/v1/dist/install-ocaml-unix.sh' failed with exit code 5
##[debug]Node Action run completed with exit code 1
##[debug]OPAMJOBS='4'
##[debug]OPAMYES='1'
##[debug]Finishing: Set up OCaml

NB: this is on a self-hosted macOS runner that caches ~/.opam between runs, so that may be affecting it somehow?

[Saviq]

Moving back to v1.1.7 made this work for us.

[Saviq]

Looks like #59 is actually what broke this for us, as it's the unconditional opam switch… is what fails.

[smorimoto]

At least there is no reason to fail. In fact, I just created a repository and set up using the cache, and it works. But I really don't recommend caching the entire switch.

[smorimoto]

Could you try not to use the old cache by adding a suffix like v1- to the head of the cache keys?

[Saviq]

Sure, this was a heavy hammer that can get improved, would be ideal if the action itself supported caching as appropriate. Building the compiler and all the dependencies every time is quite time-heavy.

In the case of this run it used a preexisting ~/.opam switch, no cache matched. I'll move it away to try again.

[smorimoto]

It's already been done as the actions-ml project. I think it will be released officially soon.
https://github.com/actions-ml