Skip to content

Fail on missing required input instead of warning #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Fail on missing required input instead of warning #629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd8a4fc
Fail on missing required input instead of warning
smorimoto Aug 31, 2022
938451a
Update CHANGELOG.md
smorimoto Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ and this project adheres to

- Add support for arm64.

### Changed

- Fail on missing required input instead of warning.

## [2.0.5]

### Changed
Expand Down
13 changes: 10 additions & 3 deletions dist/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 10 additions & 3 deletions dist/post/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 10 additions & 3 deletions src/setup-ocaml/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,46 +22,53 @@ export const CYGWIN_ROOT_BIN = path.join(CYGWIN_ROOT, "bin");
export const CYGWIN_ROOT_WRAPPERBIN = path.join(CYGWIN_ROOT, "wrapperbin");

export const CACHE_PREFIX = core.getInput("cache-prefix", {
required: false,
trimWhitespace: true,
});

export const GITHUB_TOKEN = core.getInput("github-token", {
required: false,
trimWhitespace: true,
});

export const DUNE_CACHE = core.getBooleanInput("dune-cache", {
required: false,
trimWhitespace: true,
});

export const OCAML_COMPILER = core.getInput("ocaml-compiler", {
required: true,
trimWhitespace: true,
});

export const OPAM_DEPEXT = core.getBooleanInput("opam-depext", {
required: false,
trimWhitespace: true,
});

export const OPAM_DEPEXT_FLAGS = core
.getInput("opam-depext-flags", { trimWhitespace: true })
.getInput("opam-depext-flags", { required: false, trimWhitespace: true })
.split(",")
.map((f) => f.trim())
.filter((f) => f.length > 0);

export const OPAM_DISABLE_SANDBOXING = core.getBooleanInput(
"opam-disable-sandboxing",
{ trimWhitespace: true }
{ required: false, trimWhitespace: true }
);

export const OPAM_LOCAL_PACKAGES = core.getInput("opam-local-packages", {
required: false,
trimWhitespace: true,
});

export const OPAM_PIN = core.getBooleanInput("opam-pin", {
required: false,
trimWhitespace: true,
});

const repositories_yaml = yaml.parse(
core.getInput("opam-repositories", { trimWhitespace: true })
core.getInput("opam-repositories", { required: false, trimWhitespace: true })
) as Record<string, string> | null;

const platform = getPlatform();
Expand Down