[blacklist-extensions.lua] Check if playlist entry is directory before removing #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider this directory layout:
When starting mpv with
mpv Show, and it's configured withdirectory-mode=autoordirectory-mode=lazy(the default in mpv 0.37.0 it seems, as I found out after updating), it adds subdirectories themselves to the playlist instead of their contents, only to expand them with their content when they become the current playlist item.When
remove_files_without_extensionis set totrueforblacklist_extensions.lua, directories which do not have a dot in their name are also removed from the playlist, resulting in:The issue is that
blacklist_extensions.luadoesn't check whether a playlist entry is a directory before removing it. I added the check, which then also replacedstring.find(filename, "://")sinceutils.file_info(filename)returnsnilwhen filename is a stream URL instead of the path to a local file.