build: wire up new CLDR generation tool within Bazel (angular#42230)

Introduces a few Starlark macros for running the new Bazel
CLDR generation tool. Wires up the new tool so that locales
are generated properly. Also updates the existing
`closure-locale` file to match the new output generated by the Bazel tool.

This commit also re-adds a few locale files that aren't
generated by CLDR 37, but have been accidentally left in
the repository as the Gulp script never removed old locales
from previous CLDR versions. This problem is solved with the
Bazel generation of locale files, but for now we re-add these
old CLDR 33 locale files to not break developers relying on these
(even though the locale data indicies are incorrect; but there might
be users accessing the data directly)

PR Close angular#42230

Author: devversion

.ng-dev/format.ts

@@ -26,6 +26,11 @@ export const format: FormatConfig = {
       '!dev-infra/build-worker.js',
       // Do not format compliance test-cases since they must match generated code
       '!packages/compiler-cli/test/compliance/test_cases/**/*.js',
+      // Do not format the locale files which are checked-in for Google3, but generated using
+      // the `generate-locales-tool` from `packages/common/locales`.
+      '!packages/core/src/i18n/locale_en.ts',
+      '!packages/common/locales/closure-locale.ts',
+      '!packages/common/src/i18n/currencies.ts',
     ]
   },
   'buildifier': true

packages/common/BUILD.bazel

@@ -1,7 +1,24 @@
+load("@build_bazel_rules_nodejs//:index.bzl", "generated_file_test")
+load("//packages/common/locales:index.bzl", "generate_base_currencies_file")
 load("//tools:defaults.bzl", "ng_module", "ng_package", "ts_api_guardian_test_npm_package")
 
 package(default_visibility = ["//visibility:public"])
 
+# This generates the `src/i18n/currencies.ts` file through the `generate-locales` tool. Since
+# the base currencies file is checked-in for Google3, we add a `generated_file_test` to ensure
+# the checked-in file is up-to-date. To disambiguate from the test, we use a more precise target
+# name here.
+generate_base_currencies_file(
+    name = "base_currencies_file_generated",
+    output_file = "base_currencies_generated.ts",
+)
+
+generated_file_test(
+    name = "base_currencies_file",
+    src = "src/i18n/currencies.ts",
+    generated = ":base_currencies_file_generated",
+)
+
 ng_module(
     name = "common",
     srcs = glob(

packages/common/locales/BUILD.bazel

@@ -1,18 +1,47 @@
+load("@build_bazel_rules_nodejs//:index.bzl", "generated_file_test")
+load("//packages/common/locales:index.bzl", "LOCALES", "generate_all_locale_files", "generate_closure_locales_file")
 load("//tools:defaults.bzl", "pkg_npm", "ts_library")
 
 package(default_visibility = ["//visibility:public"])
 
+# This generates the `closure-locale.ts` file through the `generate-locales` tool. Since
+# the `closure-locale.ts` file is checked-in for Google3, we add a `generated_file_test` to
+# ensure the checked-in file is up-to-date. To disambiguate from the test, we use a more
+# precise target name here.
+generate_closure_locales_file(
+    name = "closure_locales_file_generated",
+    output_file = "closure_locales_generated.ts",
+)
+
+generated_file_test(
+    name = "closure_locale_file",
+    src = "closure-locale.ts",
+    generated = ":closure_locales_file_generated",
+)
+
+generate_all_locale_files(
+    name = "locale_files",
+)
+
 ts_library(
     name = "locales",
-    srcs = glob(
-        ["**/*.ts"],
+    # TODO(devversion): Remove glob for checked-in legacy locale files that haven't been
+    # removed in the past (when CLDR has been updated). These can be removed in a major.
+    srcs = [file for l in LOCALES for file in [
+        "%s.ts" % l,
+        "extra/%s.ts" % l,
+    ]] + glob(
+        [
+            "*.ts",
+            "extra/*.ts",
+        ],
         exclude = ["closure-locale.ts"],
     ),
 )
 
 pkg_npm(
     name = "package",
-    srcs = glob(["global/*.js"]) + ["package.json"],
+    srcs = ["package.json"],
     substitutions = {
         # Workaround for `.d.ts`` containing `/// <amd-module .../>`
         # which are generated in TypeScript v2.9, but not before.
@@ -25,5 +54,7 @@ pkg_npm(
         # null out the require reference passed into the module.
         "factory\\(require, exports\\)": "factory(null, exports)",
     },
-    deps = [":locales"],
+    # TODO(devversion): Remove glob for checked-in legacy locale files that haven't been
+    # removed in the past (when CLDR has been updated). These can be removed in a major.
+    deps = ["global/%s.js" % l for l in LOCALES] + [":locales"] + glob(["global/*.js"]),
 )