Workaround for cases where glfwGetMonitorWorkarea fails #3457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI The PR for the GLFW issue is: |
ocornut
pushed a commit
that referenced
this pull request
Sep 7, 2020
|
Thank you Doug, applied to fix now! |
|
Thanks for applying this - your changes are pretty much what I'd do in my own code, but I thought it best to keep the intent of the patch clear & contained. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an issue with GLFW (not yet reported, I am working on that now) on Windows, glfwGetMonitorWorkarea can report a zero size workarea after a monitor change.
The effect of this is to cause all windows with ImGuiWindowFlags_AlwaysAutoResize set to become almost 0 size, and for some Dear ImGui interactions to fail to work properly.
The simple future proof workaround is to detect 0 size workareas and set the size to the video mode size, and the position to the MainPos as per when the function is not available.