Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opengl3: emscripten; added instance #3705

Closed
wants to merge 3 commits into from
Closed

opengl3: emscripten; added instance #3705

wants to merge 3 commits into from

Conversation

Horki
Copy link
Contributor

@Horki Horki commented Jan 9, 2021

Hi, @ocornut updated make file so web instance is automated; please test

@ocornut
Copy link
Owner

ocornut commented Jan 11, 2021

Hello,
Thanks for the PR.

  • Perhaps instead of copying and renaming the files we should instead change the build to output everything in a folder and then just serve that folder.
  • Would be good to add a reference to the serve rule in the README file.
  • I don't think mkdir -p is valid under windows.
  • .gitignore it missing a carriage return.
  • The contents of the web rule could be folded under serve.

@Horki
Copy link
Contributor Author

Horki commented Jan 11, 2021

Hi @ocornut ,

  • build is done inside web folder
  • added small reference to README; please update if it's not clear enough
  • Yes, you are right; renamed to mkdir web
  • added carriage return to .gitignore
  • done

@ocornut
Copy link
Owner

ocornut commented Jan 11, 2021

Thank you @Horki, squashed and merged + minor tweaks (added feaa7ea)

The Makefile are generally a bit ugly and wish the .o files were output in a folder there, but we'll tackle that more globally.

@ocornut ocornut closed this Jan 11, 2021
@Horki Horki deleted the emscripten_instance_gl3 branch January 11, 2021 17:49
@ocornut ocornut added the web label Jul 8, 2021
ocornut added a commit that referenced this pull request Feb 2, 2023
ocornut added a commit that referenced this pull request Feb 3, 2023
ocornut added a commit that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants