Fix integer overflow in ImFontGlyphRangesBuilder::AddRanges #4802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in an infinite loop if the user passes upper range = UINT16_MAX or UINT32_MAX with ImWchar32. Assumes IM_UNICODE_CODEPOINT_MAX < UINT32_MAX.
ocornut
pushed a commit
that referenced
this pull request
Dec 13, 2021
…passes upper range = UINT16_MAX without IMGUI_USE_WCHAR32. (#4802)
|
Thank you @SlavicPotato for the PR. |
|
Hi @ocornut, thanks! I noticed the issue after passing the 'specials' range (FFF0-FFFF). I let users define additional glyph ranges in font config files and someone might have tripped it. I wanted to avoid adding an exception for FFFF even though it's technically a non-char. |
|
Great point, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Results in an infinite loop if the user passes upper range = UINT16_MAX or UINT32_MAX with ImWchar32.
Assumes IM_UNICODE_CODEPOINT_MAX < UINT32_MAX.