Skip to content

Conversation

@craigfe
Copy link

@craigfe craigfe commented May 30, 2021

The dune file for the js_of_ocaml Graphics library is conditional on the availability of the graphics library, as determined by querying ocamlfind. This commit passes -qe to the OCamlfind query to avoid a redundant warning when graphics is not available:

$ dune build
       ocaml (internal)
ocamlfind: Package `graphics' not found

(This warning is visible to all packages that vendor js_of_ocaml.)

The `dune` file for the `js_of_ocaml` Graphics library is conditional on
the availability of the `graphics` library, as determined by querying
`ocamlfind`. This commit passes `-qe` to the OCamlfind query to avoid a
redundant warning when `graphics` is not available:

```
$ dune build
       ocaml (internal)
ocamlfind: Package `graphics' not found
```

(This warning is visible to all packages that vendor `js_of_ocaml`.)
@craigfe
Copy link
Author

craigfe commented May 30, 2021

At a higher level, it seems odd to require ocamlfind here at all, since ocamlfind is only a dep-opt of js_of_ocaml-compiler. There's a different error for not having an available ocamlfind:

$ dune build
       ocaml (internal)
sh: line 1: ocamlfind: command not found

What's the desired behaviour here when ocamlfind is not available?

@hhugo
Copy link
Member

hhugo commented Jul 7, 2021

Ideally, we should not call ocamlfind our-self. It was added some time ago to work around an issue with optional libraries 6e80150.

Do you want to try remove it and see if the CI is happy ?

@hhugo
Copy link
Member

hhugo commented Jul 28, 2021

alternative fix in #1118

@hhugo
Copy link
Member

hhugo commented Jul 29, 2021

I've removed the explicit call to ocamfind

@hhugo hhugo closed this Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants