Implement float primitives for 4.13 #1113

pmwhite · 2021-07-07T17:23:49Z

This isn't finished by any means. What's missing is

An implementation for fma
Tests

My plan for 1 is to port the native ocaml runtime's C implementation to javascript. However, I'm not sure how to do 2, since the stdlib for ocaml 4.12 does not provide functions like Float.atanh or Float.acosh, so I can't even access the primitives in a straightforward way.

If I were to write tests and run them locally using an opam switch with the 4.13 compiler, it would still break the current CI. This seems like blocker for merging this PR, since it presumably will be impossible to test until 4.13 is released.

Am I understanding things correctly?

hhugo · 2021-07-07T19:02:28Z

You can declare externals in your test directly. Just copy paste signature from ocaml master

hhugo · 2021-07-07T19:06:31Z

I'd probably put new functions in the ieee_754.js file next to other related functions

pmwhite · 2021-07-08T14:56:26Z

Moved the functions to ieee_754.js. Looks like some of the existing functions in that file re-implement functions that are builtin. If this is to act as a polyfill, maybe we should just use the polyfill as a fallback. For example:

var caml_sinh_float = Math.sinh || function (x) { return (Math.exp(x) - Math.exp(-x)) / 2; }

pmwhite · 2021-07-08T15:09:12Z

Looks like compiler/test-ocaml/lib-float/test.ml is taken directly from the ocaml compiler. Oddly enough, it seems to be lacking tests for several of the builtin functions. It would be nice if the ocaml's stdlib tests were available in opam so that we could just depend on that instead of manually keeping these files up-to-date.

Anyway, I take it that tests should go in compiler/tests-jsoo/test_floats.ml

TyOverby · 2021-07-08T15:53:46Z

runtime/ieee_754.js

+  return function cbrt(x) {
+    return x < 0 ? -pow(x, 1/3) : pow(x, 1/3);
+  };
+})(Math.pow);


Why pass pow in like this?

All these polyfill implementations are taken from the MDN docs. This one, in particular was taken from https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/cbrt

pmwhite · 2021-07-08T21:16:11Z

Added some tests. The situation is not ideal because the ocaml stdlib doesn't have these functions defined yet, so these tests can't be run in native mode (I disabled native mode for all the tests in this directory, but if there's no workaround, I should probably put the float tests in their own library so we can disable native code for just the float tests.

hhugo · 2021-07-09T06:32:45Z

Moved the functions to ieee_754.js. Looks like some of the existing functions in that file re-implement functions that are builtin. If this is to act as a polyfill, maybe we should just use the polyfill as a fallback. For example:
var caml_sinh_float = Math.sinh || function (x) { return (Math.exp(x) - Math.exp(-x)) / 2; }

We don't need polyfill for things that are well supported. It's possible that polyfill were added in the past if support was not great at the time.

hhugo · 2021-07-09T06:36:09Z

Added some tests. The situation is not ideal because the ocaml stdlib doesn't have these functions defined yet, so these tests can't be run in native mode (I disabled native mode for all the tests in this directory, but if there's no workaround, I should probably put the float tests in their own library so we can disable native code for just the float tests.

Maybe move the tests in theirs on lib for now.

pmwhite · 2021-07-22T13:25:28Z

@hhugo I'm finished implementing and testing these functions, so this is ready to be reviewed. The fma implementation I took from this gist, and the fma tests I took from the ocaml compiler. The aforementioned gist passed all the tests without modification.

The fma implementation is taken from https://gist.github.com/Yaffle/fb47de4c18b63147699e0b621f1031f7 The tests were taken directly from the ocaml testsuite and modified to be expect-tests.

hhugo · 2021-07-28T13:59:39Z

I've tested your PR with 4.13 and made a small fix regarding nan printing in the tests. I've also rebased your work on top of the latest master.

hhugo · 2021-07-28T14:03:53Z

Would you mind adding a changelog entry ?

pmwhite · 2021-07-29T14:28:56Z

Ahh, sorry for being slow to correct the formatting and changelog. Thanks!

hhugo · 2021-07-29T15:11:14Z

Thanks for working on this

…s_of_ocaml-ppx_deriving_json, js_of_ocaml-ppx, js_of_ocaml-ocamlbuild, js_of_ocaml-lwt and js_of_ocaml-compiler (3.10.0) CHANGES: ## Features/Changes * Compiler: add support for OCaml 4.13 * Compiler: new tool to check for missing primitives * Compiler: drop support for OCaml 4.03 and bellow * Lib: add offsetX and offsetY to Dom_html.mouseEvent * Lib: add innerText property for Dom_html * Runtime: add dummy implementation for many dummy primitives * Runtime: add runtime for new float operation in 4.13 ocsigen/js_of_ocaml#1113 (by pmwhite) ## Misc * manual/rev_bindings.wiki: fix compilation error

TyOverby reviewed Jul 8, 2021

View reviewed changes

pmwhite and others added 10 commits July 28, 2021 05:01

Runtime: add float primitives

f90c27c

Move functions to more appropriate file

2378068

Add tests for float operations

041c86c

Move float tests to their own library for now

195235c

Stop using polyfills for well-support float functions

159c155

runtime: fix typo in erfc and erf implementation

49f23e8

runtime: add fma implementation with tests

59addfa

The fma implementation is taken from https://gist.github.com/Yaffle/fb47de4c18b63147699e0b621f1031f7 The tests were taken directly from the ocaml testsuite and modified to be expect-tests.

runtime: remove spurious javascript cast in fma

5b2c51c

Tests: normalize output in the nan case

a1e367f

Misc: fmt

d4bd860

hhugo force-pushed the master branch from 651215e to 8759705 Compare July 28, 2021 13:57

hhugo changed the title ~~WIP: Implement float primitives for 4.13~~ Implement float primitives for 4.13 Jul 28, 2021

hhugo force-pushed the master branch from 8759705 to a1e367f Compare July 28, 2021 14:01

Change

68f2376

hhugo merged commit 23b25ca into ocsigen:master Jul 29, 2021

hhugo mentioned this pull request Aug 30, 2021

[new release] js_of_ocaml, js_of_ocaml-tyxml, js_of_ocaml-toplevel, js_of_ocaml-ppx_deriving_json, js_of_ocaml-ppx, js_of_ocaml-ocamlbuild, js_of_ocaml-lwt and js_of_ocaml-compiler (3.10.0) ocaml/opam-repository#19365

Merged

Implement float primitives for 4.13 #1113

Implement float primitives for 4.13 #1113

Uh oh!

Conversation

pmwhite commented Jul 7, 2021 • edited by hhugo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hhugo commented Jul 7, 2021

Uh oh!

hhugo commented Jul 7, 2021

Uh oh!

pmwhite commented Jul 8, 2021

Uh oh!

pmwhite commented Jul 8, 2021

Uh oh!

TyOverby Jul 8, 2021

Choose a reason for hiding this comment

Uh oh!

pmwhite Jul 8, 2021

Choose a reason for hiding this comment

Uh oh!

pmwhite commented Jul 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hhugo commented Jul 9, 2021

Uh oh!

hhugo commented Jul 9, 2021

Uh oh!

pmwhite commented Jul 22, 2021

Uh oh!

hhugo commented Jul 28, 2021

Uh oh!

hhugo commented Jul 28, 2021

Uh oh!

pmwhite commented Jul 29, 2021

Uh oh!

hhugo commented Jul 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pmwhite commented Jul 7, 2021 •

edited by hhugo

Loading

pmwhite commented Jul 8, 2021 •

edited

Loading