Skip to content

Conversation

@jmid
Copy link
Contributor

@jmid jmid commented Jun 30, 2022

This PR bumps the magic numbers to suffix 32 to match the upcoming 5.0.0 ones: ocaml/ocaml@293014b. Without it jsoo will fail on 5.0.0~alpha0-compiled bytecode:

$ cat hello.ml 
let _ = print_endline "hello, world!"
$ ocamlc -o hello.byte hello.ml
$ js_of_ocaml hello.byte 
js_of_ocaml: Error: Bytecode version mismatch.
js_of_ocaml: Error: Your ocaml bytecode and the js_of_ocaml compiler have to be compiled with the same version of ocaml.
js_of_ocaml: Error: The Js_of_ocaml compiler has been compiled with ocaml version 5.0.0~alpha0.
js_of_ocaml: Error: Its seems that your ocaml bytecode has been compiled with a newer version of ocaml.

@smorimoto
Copy link
Member

@jmid The change log entry is needed. Could you add that?

@jmid
Copy link
Contributor Author

jmid commented Jun 30, 2022

Sure! Done in da1bf3c 😃

@hhugo hhugo merged commit 9b82bd9 into ocsigen:master Jun 30, 2022
@jmid jmid deleted the bump-magic-numbers branch June 30, 2022 16:26
OlivierNicole pushed a commit to OlivierNicole/js_of_ocaml that referenced this pull request Sep 9, 2022
* bump magic number to match 5.0.0~alpha0

* Update CHANGELOG
hhugo pushed a commit to hhugo/opam-repository that referenced this pull request Nov 15, 2022
…s_of_ocaml-ppx_deriving_json, js_of_ocaml-ppx, js_of_ocaml-lwt and js_of_ocaml-compiler (4.1.0)

CHANGES:

## Features/Changes
* Compiler: initial support for OCaml 5 (ocsigen/js_of_ocaml#1265,ocsigen/js_of_ocaml#1303)
* Compiler: bump magic number to match the 5.0.0~alpha0 release (ocsigen/js_of_ocaml#1288)
* Compiler: complain when runtime and compiler built-in primitives disagree (ocsigen/js_of_ocaml#1312)
* Compiler: more efficient implementation of Js_traverse.freevar
* Compiler: more efficient implementation of Js_traverse.rename_variable
* Compiler: --linkall now export all compilation units in addition to primitives (ocsigen/js_of_ocaml#1324)
* Compiler: improve --dynlink, one no longer need to pass --toplevel to use Dynlink (ocsigen/js_of_ocaml#1324)
* Compiler: toplevel runtime files "+toplevel.js" and "+dynlink.js" are added automatically (ocsigen/js_of_ocaml#1324)
* Misc: switch to cmdliner.1.1.0
* Misc: remove old binaries jsoo_link, jsoo_fs
* Misc: remove uchar dep
* Misc: use 4.14 in the CI
* Misc: switch to dune 3
* Lib: add missing options for Intl.DateTimeFormat
* Lib: add missing options for Intl.NumberFormat
* Lib: wheel event binding
* Lib: add normalize in js_string (ES6)
* Lib: more complete transition event bindings
* Lib: remove support for old browser-specific transition events
* Runtime: Implement weak semantic for weak and ephemeron
* Runtime: Implement Gc.finalise_last
* Runtime: Implement buffer for in_channels
* Runtime: add support for unix_opendir, unix_readdir, unix_closedir, win_findfirst, win_findnext, win_findclose
* Runtime: Dont use require when target-env is browser
* Runtime: Implements Parsing.set_trace (ocsigen/js_of_ocaml#1308)
* Test: track external used in the stdlib and unix

## Bug fixes
* Compiler: fix quadratic behavior of dominance frontier (fix ocsigen/js_of_ocaml#1300)
* Compiler: fix rewriter bug in share_constant (fix ocsigen/js_of_ocaml#1247)
* Compiler: fix miscompilation of mutually recursive functions in loop (ocsigen/js_of_ocaml#1321)
* Compiler: fix bug while minifying/renaming try-catch blocks
* Compiler: no dead code elimination for caml_js_get
* Runtime: fix ocamlyacc parse engine (ocsigen/js_of_ocaml#1307)
* Runtime: fix Out_channel.is_buffered, set_buffered
* Runtime: fix format wrt alternative
* Runtime: fix Digest.channel
* Runtime: sync channel seek / pos with the native runtime
* Misc: fix installation with dune 3 without opam
* Node: Only write small chunks to stdout/stderr so they flush
* Deriving: fix for nested polymorphic variants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants