-
Notifications
You must be signed in to change notification settings - Fork 197
Doc: document findlib interaction #1323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dbuenzli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. The convention and mechanics looks good to me. I left a few comments.
|
One more thing. In case you have a single |
added |
dbuenzli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a quick look at the changes it looks mostly ok to me. Thank you.
If you really want to polish I would rather call the runtime-files page, "How to compile a program" and make it centered on that but I guess most people are not interested in the base invocations and the current organisation is enough for build system fiddlers.
Btw. maybe I dreamt but at some point I thought I had bought you into converting the docs to .mld files :-) I still think it would be worthwhile, the docs should show up on ocaml.org (and in odig doc js-of-ocaml-compiler if you are a local documentation addict).
I was more tempted to deprecated |
Well you can use |
And you can use the toplevel without dynlink. In theory, you're not allowed to use Dynlink inside the toplevel. Dynlink can only be used if Js_of_ocaml_toplevel is initialized. |
Somehow a
That looks like a jsoo implementation detail. For me toplevel is really the interactive behaviour so it feels a bit strange to me to use the But in any case what do these flags do ? What do they enable ? And do they actually do exactly the same thing ? Based on these answers maybe we can find a new entirely different technical name and deprecate the other twos if you find neither suitable. |
I'd like to restructure the entire doc eventually but will leave the doc as is for now
I'd like some kind of agreement with other ocsigen devs before. Mostly concerned about the ocsigen.org website. |
Let's move that discussion to #1324 |
cc @dbuenzli, in case you want to review