Skip to content

Compiler: joo_global_object is deprecated #1695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Compiler: joo_global_object is deprecated #1695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
prevision for the merge of wasm_of_ocaml
* Compiler: introduce a Targetint module
that follows the semantic of the backend (js or wasm)
* Compiler: warn on joo_global_object
* Runtime: change Sys.os_type on windows (Cygwin -> Win32)
* Runtime: backtraces are really expensive, they need to be be explicitly
requested at compile time (--enable with-js-error) or at startup (OCAMLRUNPARAM=b=1)
Expand Down
5 changes: 1 addition & 4 deletions compiler/lib/linker.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,7 @@ module Check = struct
let freename = StringSet.diff freename Reserved.provided in
let freename = StringSet.remove Global_constant.global_object freename in
let freename = if has_flags then StringSet.remove "FLAG" freename else freename in
if StringSet.mem Global_constant.old_global_object freename && false
(* Don't warn yet, we want to give a transition period where both
"globalThis" and "joo_global_object" are allowed without extra
noise *)
if StringSet.mem Global_constant.old_global_object freename
then
warn
"warning: %s: 'joo_global_object' is being deprecated, please use `globalThis` \
Expand Down