Skip to content

Compiler: dynlink javascript files #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 17, 2016
Merged

Compiler: dynlink javascript files #480

merged 2 commits into from
May 17, 2016

Conversation

@hhugo
Copy link
Member

@hhugo hhugo commented May 16, 2016

Following #313
Allow to dynlink precompiled ocaml units (aka javascript files).

In the toplevel, one can already do the following to compile bytecode to javascript and execute it.

#load "/static/test_dynlink.cmo

One can now load precompiled javascript directly.

#load_js "test_dynlink.js"

#369
#450

hhugo added a commit to hhugo/jsoo-dynload-test that referenced this pull request May 17, 2016
@hhugo
Update compile.sh
d4ddd16 
fix example using ocsigen/js_of_ocaml#480
One can now dynlink javascript file directly
This was referenced May 17, 2016
Merged
Closed
@hhugo hhugo merged commit c053957 into master May 17, 2016
@hhugo hhugo deleted the dynlink branch May 17, 2016 09:49
@ejgallego
Copy link
Contributor

ejgallego commented May 18, 2016

This is fantastic, thanks!

@ejgallego ejgallego mentioned this pull request May 20, 2016
Closed
@SanderSpies SanderSpies mentioned this pull request Sep 9, 2017
Closed
hhugo added a commit that referenced this pull request Nov 14, 2022
@hhugo
Toplevel: no longer generates dummy stubs for missing primitives
a80e205 
This logic was broken due to #1324
which made the it run before the toplevel/dynlink was initialized.

These generated primitives where never used in practice because the generated
code always uses jsoo_runtime to access primitives.
#480
hhugo added a commit that referenced this pull request Nov 14, 2022
@hhugo
Toplevel: no longer generates dummy stubs for missing primitives
af463b6 
This logic was broken due to #1324
which made the it run before the toplevel/dynlink was initialized.

These generated primitives where never used in practice because the generated
code always uses jsoo_runtime to access primitives.
#480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hhugo @ejgallego