Skip to content

Change type of Dom_html.storageEvent #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2017
Merged

Change type of Dom_html.storageEvent #582

merged 2 commits into from
Jun 13, 2017

Conversation

@xvw
Copy link
Contributor

@xvw xvw commented May 15, 2017

When we use aStorage##clear(), the key value could be null.

@sagotch
Copy link
Contributor

sagotch commented May 15, 2017

Not a comment about the PR, but why is it called keynewValue ? It probably should be newValue instead.

@xvw
Copy link
Contributor Author

xvw commented May 15, 2017

Agreed !

@hhugo hhugo merged commit c1855e0 into ocsigen:master Jun 13, 2017
@hhugo
Copy link
Member

hhugo commented Jun 13, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xvw @sagotch @hhugo