Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 21, 2020

Bumps typescript from 3.7.5 to 3.9.3.

Release notes

Sourced from typescript's releases.

TypeScript 3.9.3

This release contains bug fixes in type-checking, APIs, emit, and editor scenarios.

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 3.9.2

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 3.9 RC

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 3.9 Beta

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

... (truncated)
Commits
Maintainer changes

This version was pushed to npm by typescript-bot, a new releaser for typescript since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label May 21, 2020
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/typescript-3.9.3 branch from c44523f to f288cc3 Compare May 21, 2020 06:58
@gr2m gr2m self-assigned this May 21, 2020
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/typescript-3.9.3 branch from f288cc3 to 02a2e74 Compare May 21, 2020 07:10
@gr2m
Copy link
Contributor

gr2m commented May 21, 2020

very weird typescript error :/

 FAIL  test/defaults.test.ts
  ● Test suite failed to run

    TypeScript diagnostics (customize using `[jest-config].globals.ts-jest.diagnostics` option):
    src/fetch-wrapper.ts:27:5 - error TS2345: Argument of type '{ method: RequestMethod; body: any; headers: RequestHeaders; redirect: string | undefined; } & RequestRequestOptions' is not assignable to parameter of type 'RequestInit | undefined'.
      Type '{ method: RequestMethod; body: any; headers: RequestHeaders; redirect: string | undefined; } & RequestRequestOptions' is not assignable to type 'RequestInit'.
        Types of property 'headers' are incompatible.
          Type 'RequestHeaders' is not assignable to type 'Headers | string[][] | { [key: string]: string; } | undefined'.
            Type 'RequestHeaders' is missing the following properties from type 'string[][]': length, pop, push, concat, and 26 more.

     27     Object.assign(
            ~~~~~~~~~~~~~~
     28       {
        ~~~~~~~
    ... 
     34       requestOptions.request
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     35     )
        ~~~~~

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/typescript-3.9.3 branch from 02a2e74 to 27b2f17 Compare May 21, 2020 07:23
@gr2m gr2m force-pushed the dependabot/npm_and_yarn/typescript-3.9.3 branch from 27b2f17 to 7e6ab22 Compare May 21, 2020 18:24
@gr2m
Copy link
Contributor

gr2m commented May 21, 2020

Tests pass with TypeScript 3.75

gr2m added a commit that referenced this pull request May 21, 2020
gr2m added a commit that referenced this pull request May 21, 2020
@gr2m gr2m force-pushed the dependabot/npm_and_yarn/typescript-3.9.3 branch 2 times, most recently from a00fc0e to c9f85da Compare May 25, 2020 07:06
@ram-nad
Copy link
Contributor

ram-nad commented May 30, 2020

Might have something to do with this.

https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-9.html#stricter-checks-on-intersections-and-optional-properties

@ram-nad
Copy link
Contributor

ram-nad commented May 30, 2020

One fix that might work is to change [header: string]: string | number | undefined to [header: string]: string in https://github.com/octokit/types.ts/blob/master/src/RequestHeaders.ts. I haven't tried it though.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 5, 2020

A newer version of typescript exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@gr2m
Copy link
Contributor

gr2m commented Jun 11, 2020

One fix that might work is to change [header: string]: string | number | undefined to [header: string]: string in https://github.com/octokit/types.ts/blob/master/src/RequestHeaders.ts. I haven't tried it though.

I tried, no luck

@gr2m gr2m force-pushed the dependabot/npm_and_yarn/typescript-3.9.3 branch from c9f85da to efea43a Compare June 11, 2020 21:17
@gr2m gr2m changed the title build(deps-dev): bump typescript from 3.7.5 to 3.9.3 build(deps-dev): bump typescript from 3.7.5 to 3.9.5 Jun 11, 2020
@gr2m gr2m merged commit 1ac2c6e into master Jun 11, 2020
@gr2m gr2m deleted the dependabot/npm_and_yarn/typescript-3.9.3 branch June 11, 2020 21:29
@github-actions
Copy link

🎉 This PR is included in version 5.4.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants