Skip to content

remove undocumented error.status #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gr2m merged 2 commits into from
Oct 24, 2018
Merged

remove undocumented error.status #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91a6bfb
fix: remove undocumented `error.status`
gr2m Oct 24, 2018
1b41bb5
fix: remove undocumented error.headers
gr2m Oct 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 5 additions & 15 deletions lib/http-error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,14 @@
'use strict'

const STATUS_CODES = {
304: 'Not Modified', // See PR #673 (https://github.com/octokit/rest.js/pull/673)
400: 'Bad Request',
404: 'Not Found',
500: 'Internal Server Error',
504: 'Gateway Timeout'
}

module.exports = class HttpError extends Error {
constructor (message, code, headers) {
constructor (message, code) {
super(message)
// Maintains proper stack trace for where our error was thrown (only available on V8)
/* istanbul ignore else */

// Maintains proper stack trace (only available on V8)
/* istanbul ignore next */
if (Error.captureStackTrace) {
Error.captureStackTrace(this, this.constructor)
}

this.name = 'HttpError'
this.code = code
this.status = STATUS_CODES[code]
this.headers = headers
}
}