Skip to content

fix(fetch-wrapper): improve error message when 'fetch' implementation is not present #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2023
Merged

fix(fetch-wrapper): improve error message when 'fetch' implementation is not present #617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/fetch-wrapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export default function fetchWrapper(

if (!fetch) {
throw new Error(
'Global "fetch" not found. Please provide `options.request.fetch` to octokit or upgrade to node@18 or newer.',
"fetch is not set. Please pass a fetch implementation as new Octokit({ request: { fetch }}). Learn more at https://github.com/octokit/octokit.js/#fetch-missing",
);
}

Expand Down
2 changes: 1 addition & 1 deletion test/request.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ x//0u+zd/R/QRUzLOw4N72/Hu+UG6MNt5iDZFCtapRaKt6OvSBwy8w==
}
globalThis.fetch = originalFetch;
expect(error?.message).toEqual(
'Global "fetch" not found. Please provide `options.request.fetch` to octokit or upgrade to node@18 or newer.',
"fetch is not set. Please pass a fetch implementation as new Octokit({ request: { fetch }}). Learn more at https://github.com/octokit/octokit.js/#fetch-missing",
);
});

Expand Down