[FIX] core: square up guess_mimetype implementations

`_odoo_guess_mimetype` requires bytes upfront as `_Entry.signatures`
are lists of bytes, thus `bin_data.startswith(signature)` requires
that `bin_data` be `bytes`.

Forthe libmagic version this is a bit more dodgy: `magic` accepts
`str` (and encodes under the hood if so) for Python 2 compatibility
reasons, but the `guess_mimetypes` wrapper will trigger an unhelpful
warning if libmagic recognizes a zip or ole file.

Update the libmagic version to reject str inputs.

Part-of: odoo#238151
Related: odoo/enterprise#100985
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

Author: xmo-odoo

odoo/tools/mimetypes.py

@@ -150,11 +150,11 @@ def _check_webp(data):
     # zip, but will include jar, odt, ods, odp, docx, xlsx, pptx, apk
     _Entry('application/zip', [b'PK\x03\x04'], [_check_ooxml, _check_open_container_format]),
 )
-def _odoo_guess_mimetype(bin_data, default='application/octet-stream'):
+def _odoo_guess_mimetype(bin_data: bytes, default='application/octet-stream'):
     """ Attempts to guess the mime type of the provided binary data, similar
     to but significantly more limited than libmagic
 
-    :param str bin_data: binary data to try and guess a mime type for
+    :param bin_data: binary data to try and guess a mime type for
     :returns: matched mimetype or ``application/octet-stream`` if none matched
     """
     # by default, guess the type using the magic number of file hex signature (like magic, but more limited)
@@ -189,6 +189,8 @@ def _odoo_guess_mimetype(bin_data, default='application/octet-stream'):
     def guess_mimetype(bin_data, default=None):
         if isinstance(bin_data, bytearray):
             bin_data = bytes(bin_data[:1024])
+        elif not isinstance(bin_data, bytes):
+            raise TypeError('`bin_data` must be bytes or bytearray')
         mimetype = magic.from_buffer(bin_data[:1024], mime=True)
         if mimetype in ('application/CDFV2', 'application/x-ole-storage'):
             # Those are the generic file format that Microsoft Office