Skip to content

[IMP] Documents: email alias #10024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Donapi wants to merge 1 commit into from
Closed

[IMP] Documents: email alias #10024

Donapi wants to merge 1 commit into from

Conversation

@Donapi
Copy link
Contributor

@Donapi Donapi commented Jul 1, 2024 •
edited
Loading

taskid-3898917
to be updated in 17.3

@robodoo
Copy link
Collaborator

robodoo commented Jul 1, 2024

Pull request status dashboard

@Donapi Donapi marked this pull request as ready for review July 1, 2024 14:59
@C3POdoo C3POdoo requested a review from a team July 1, 2024 15:00
@Donapi Donapi force-pushed the saas-17.2-documents-dopi branch from 8b315d7 to ef5e18f Compare July 5, 2024 08:36
@Donapi Donapi requested a review from a team July 5, 2024 08:47
auva-odoo
auva-odoo requested changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Donapi don't hesitate if you have any questions or want to discuss anything 🙂

@Donapi Donapi force-pushed the saas-17.2-documents-dopi branch 2 times, most recently from 2c416e1 to 67c9e04 Compare July 15, 2024 07:56
@Donapi Donapi requested review from a team and auva-odoo July 15, 2024 08:25
auva-odoo
auva-odoo requested changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Donapi as I mentioned in a reply to one of my comments, I think there's a missing paragraph compared to the first version of this PR, could you please check?
I also added another comment on lines 253-257.

@Donapi Donapi force-pushed the saas-17.2-documents-dopi branch from 67c9e04 to 8dec778 Compare July 16, 2024 14:51
@Donapi
Copy link
Contributor Author

Donapi commented Jul 16, 2024

Hi @Donapi as I mentioned in a reply to one of my comments, I think there's a missing paragraph compared to the first version of this PR, could you please check? I also added another comment on lines 253-257.

@auva-odoo Sorry that I missed your comment! It should be fine now :)

@Donapi Donapi requested a review from auva-odoo July 16, 2024 14:52
@auva-odoo
Copy link
Contributor

auva-odoo commented Jul 17, 2024

Hi @Donapi as I mentioned in a reply to one of my comments, I think there's a missing paragraph compared to the first version of this PR, could you please check? I also added another comment on lines 253-257.

@auva-odoo Sorry that I missed your comment! It should be fine now :)

You didn't miss it, I saw it yesterday 😉 I think it went missing went you force-pushed your changes after my first review. I see the paragraph now (on lines 227-230; for some reason it now makes it look like this isn't something you changed in this PR although it was), but without the changes that I suggested, could you please check my original comment again?

auva-odoo
auva-odoo reviewed Jul 17, 2024
View reviewed changes
content/applications/productivity/documents.rst Outdated
Comment on lines 257 to 262
- Your **email server** must be configured to be able to create an **email alias**. If it isn't
configured yet, click :guilabel:`Choose or Configure Email Servers` and configure the
:doc:`mail server <../../applications/general/email_communication/email_servers>`;
- By default, the :guilabel:`Document Owner` is the person who uploads a file to a workspace, but
you can select another user. You can also set a :guilabel:`Contact`, usually an external
person, such as a partner.
person, such as a partner;
Copy link
Contributor

@auva-odoo auva-odoo Jul 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and these can get a period at the end since they're full sentences 🙂

@Donapi Donapi force-pushed the saas-17.2-documents-dopi branch from 8dec778 to c5dcea7 Compare July 18, 2024 07:25
@Donapi Donapi requested a review from auva-odoo July 18, 2024 07:26
auva-odoo
auva-odoo approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo r+

robodoo pushed a commit that referenced this pull request Jul 18, 2024
@Donapi
[IMP] Documents: email alias
b2ba466 
taskid-3898917

closes #10024

Signed-off-by: Audrey Vandromme (auva) <auva@odoo.com>
@fw-bot fw-bot mentioned this pull request Jul 18, 2024
Closed
@robodoo robodoo closed this Jul 18, 2024
@fw-bot fw-bot mentioned this pull request Jul 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@auva-odoo auva-odoo auva-odoo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Donapi @robodoo @auva-odoo