[ADD] Sales: adding doc about variants in orders

[vpk-odoo]

Task: https://www.odoo.com/web#id=2574874&action=333&active_id=3835&model=project.task&view_type=form&cids=3&menu_id=4720

[xpl-odoo]

You should add the doc to its toctree: sales\send_quotations.rst, as noted when you do make html
Note that you can order (and re-order) the toctree's docs: you don't need to add your new doc at the end of the list of docs - unless you think it should be last ;)

Also, did you think about moving this doc together with the other doc about variants you just updated sales\products_prices\products\variants.rst? I guess a case could be made to have the doc at either of the two locations, but I would group both docs about variants. @jcs-odoo, any opinion on that?

Don't forget to pngquant your screenshots :)

Finally, I see that you have the same problem as I did: you often have line breaks a bit before 100 characters: that's probably due to the Warp on typing option which doesn't always work properly - myself I disabled it recently and now do it manually, which is rather easy with the visual guide (the vertical line)

[jcs-odoo]

Also, did you think about moving this doc together with the other doc about variants you just updated sales\products_prices\products\variants.rst? I guess a case could be made to have the doc at either of the two locations, but I would group both docs about variants. @jcs-odoo, any opinion on that?

Ola @xpl-odoo !

I haven't read this PR nor its content yet but so you know: @vpk-odoo and I talked about this last week;
this doc in Sales should only cover the usage of variants in Sales whereas the configuration of products shall move to general.

vpk also updates the file content/applications/sales/sales/products_prices/products/variants.rst with content that she's already written (I haven't read in detail yet either) and it should include all info about variants configuration (so have a look at what's in e-commerce, maybe, although there isn't much).

And I'll do the move of the file content/applications/sales/sales/products_prices/products/variants.rst (along with others) to general myself, and merge most of the similar content in e-commerce as well (merge meaning "delete", from a technical point of view ^^).

[xpl-odoo]

Very minor changes/suggestions. Almost ready for the next stage :)

[robodoo]

Sorry, I didn't know about this PR and had to retrieve its information, you may have to re-approve it.

[robodoo]

Pull request status dashboard.

[samueljlieber]

Hey @meng-odoo 👋
I updated this documentation to work on the latest 14.0 updates and it is ready for a content review. Let me know if you have any suggestions for improvement!

[meng-odoo]

Hi @samueljlieber ! I ended up largely rewriting whole paragraphs at a time for this doc. Please let me know if you have any questions :) thanks!

[samueljlieber]

Hi @meng-odoo! Thanks for writing up the RST in your changes 🙂! I've updated the document, ready for review!

[meng-odoo]

Hi @samueljlieber , thanks for making those changes! I just have a few more tiny ones before we tag the next reviewer. Thank you :)

[samueljlieber]

Hi @meng-odoo, the RST has been updated to your latest changes 👍

[meng-odoo]

Hi @samueljlieber thanks again for making those changes! Everything looks good. I'll tag the next reviewer :)

[mivu-odoo]

Hello @meng-odoo and @samueljlieber! Great work on this PR!

I only had a couple suggestions for concision and clarity. Some images also need to be replaced. Two images should be deleted variants-in-description.png (it's visually confusing) and grid-entry-popup.png (it's not even referenced in the RST file at all).

Please let me know when you're ready for a second look. Thank you 😸

[samueljlieber]

Hi @mivu-odoo 🙂
Thanks for the suggestions! I've updated the document and removed the unused image - all set for your second review!

[mivu-odoo]

Hello @samueljlieber and @meng-odoo!

Thank you for the new images and fixes to the doc! I flagged two small things that should be changed on my second pass.

Once that's pushed, this PR is good to move forward to the next step! No need to tag me again for a final content review. Not sure if ZST gave any instruction on what to do about final technical review while he's out on vacation this week.

If he didn't give any instruction, @samueljlieber up to you whether or not you want to tag ZST on this PR and wait for him to come back, or if you want to push it straight to the /doc-review team so we can merge and close this PR.

[samueljlieber]

Hi @StraubCreative 👋
This PR is ready for a final technical review!

[StraubCreative]

Seems good 👍
Tagging @odoo/doc-review for final review.

[AntoineVDV]

Almost good to go 👍

[samueljlieber]

Hi @AntoineVDV thank you, I made the change 🙂

CC @StraubCreative

[AntoineVDV]

@robodoo r+