[IMP] inventory: CRL - replenishment & visibility days #11444

Felicious · 2024-11-22T01:38:55Z

Fix inaccuracies about visibility days explanation, with improved example and supportive imagery to visualize how the dates work together.

Changelog

restructure reordering rules documentation by pulling the section about how the replenishment report works into a new document
Elaborate more about preferred route + other advanced fields
Explain just-in-time logic
Explain how the Forecasted quantities are determined
Create custom visualizations for visibility days and forecasted date
Backport explanation about days to purchase (may run into merge conflicts when fwporting because of the internal links' naming scheme!)

FWport: to master

robodoo · 2024-11-22T01:38:58Z

Felicious · 2024-11-22T14:42:19Z

The BE expert reached out and told me there's still stuff for me to improve 🙈 I'll ping you on discord when this PR is ready, @hojo-odoo !

Felicious · 2024-11-27T03:59:06Z

Hi @hojo-odoo ! This PR is ready for review!

https://runbot158.odoo.com/runbot/static/build/71189420-16-0/logs/build/html/applications/inventory_and_mrp/inventory/warehouses_storage/replenishment/report.html

Felicious · 2025-01-08T02:54:14Z

Wanted to log here that I've received extensive help from Charlotte (crl), who in each review, provided a ton of feedback and resources to enhance our documentation. Based on her feedback, this PR grew and grew and touched more files, with the following reviews and dates:

Nov 21: first review explaining visibility days
Nov 22: major rework and restructure of reordering rules documentation. Exalidraw of feedback
Dec 21: major rework of replenishment, reporting, and reordering rules documentation. Exalidraw of feedback
Hopefully, with this update, this is the final review (:

Felicious · 2025-01-24T07:32:50Z

Finished another round of feedback from CRL: https://app.excalidraw.com/l/65VNwvy7c4X/6bfO4CXWwKr

Felicious · 2025-01-24T07:38:45Z

Hi @benderliz 😊 To try to help you gain exposure to replenishment through Odoo, can I get your help reviewing this reallyy massive PR? There are four documents that were changed:

replenishment.rst
replenishment/lead_times.rst
replenishment/reordering_rules.rst (this is the one that changed the most!)
replenishment/report.rst (where I tried to dump excess stuff from reordering rules here, in a futile attempt to keep it lean)

I mostly need help with reordering_rules. Should I ask @hojo-odoo to help review lead_times.rst and replenishment.rst?

samueljlieber

Hi @Felicious! I just want to say thank you for all of your hard work on this massive PR to improve and clarify the varying replenishment options and configurations.

I've reviewed CRLs incredibly helpful excalidraws against the current state of your PR and everything is looking pretty good to me! I found a couple instances you may want to double check, as well as a couple technical things to fix, and of course some optional suggestions :)

Please note this is just another peer review, due to the size of this PR, please tag me again after @benderliz's review for a final tech review. Thank you! 🚀

...plications/inventory_and_mrp/inventory/warehouses_storage/replenishment/reordering_rules.rst

content/applications/inventory_and_mrp/inventory/warehouses_storage/replenishment/report.rst

content/applications/inventory_and_mrp/inventory/warehouses_storage/replenishment.rst

Felicious · 2025-01-29T00:32:48Z

@benderliz Reminder to review this (:

benderliz

Something happened and I can't see my comments...finishing review to see if they re-appear

content/applications/inventory_and_mrp/inventory/warehouses_storage/replenishment.rst

benderliz · 2025-01-30T17:11:05Z

content/applications/inventory_and_mrp/inventory/warehouses_storage/replenishment.rst

+Each triggers the creation or suggestion of a purchase order (PO) or manufacturing order (MO), with
+the best choice depending on the business process.
+
+.. cards::


This is such a cool UI feature, Felicia! Love this choice. I think I found an RST fix for making the column size of the cards more equal (in the runbot rendering, they're sized unequally).
I am thinking it's this width syntax. I would guess they should each be set to 33%? Here's the how-to article: https://sphinx-design.readthedocs.io/en/latest/cards.html

I purposefully made reordering rules bigger because it's the most relevant doc of the three (:

content/applications/inventory_and_mrp/inventory/warehouses_storage/replenishment.rst

...plications/inventory_and_mrp/inventory/warehouses_storage/replenishment/reordering_rules.rst

benderliz · 2025-01-30T19:22:09Z

...plications/inventory_and_mrp/inventory/warehouses_storage/replenishment/reordering_rules.rst

+
+- :guilabel:`Vendor`: When the selected :guilabel:`Preferred Route` is :guilabel:`Buy`, setting the
+  :guilabel:`Vendor` field to one of the multiple vendors on the vendor pricelist indicates to Odoo
+  that is the vendor to prioritize when making orders.


Be more explicit - if that is the vendor to prioritize, does Odoo automatically populate this vendor on POs then?

benderliz · 2025-01-30T19:26:47Z

...plications/inventory_and_mrp/inventory/warehouses_storage/replenishment/reordering_rules.rst

+
+- :guilabel:`Bill of Materials`: When the :guilabel:`Preferred Route` is set to
+  :guilabel:`Manufacture`, and there are multiple |BoMs| in use, specifying the desired |BoM| in the
+  replenishment report prioritizes it for draft manufacturing orders triggered by reordering rules.


Same question - what does prioritizing mean in this context?

...plications/inventory_and_mrp/inventory/warehouses_storage/replenishment/reordering_rules.rst

benderliz · 2025-01-30T19:32:36Z

...plications/inventory_and_mrp/inventory/warehouses_storage/replenishment/reordering_rules.rst

+
+- :guilabel:`Procurement Group`: is a way to group related purchase or manufacturing orders that
+  are tied to fulfilling a specific demand, like a |SO| or a project. It helps organize and track
+  which orders are linked to a particular demand.


Not sure what is meant by "a particular demand".

benderliz · 2025-01-30T19:35:01Z

...plications/inventory_and_mrp/inventory/warehouses_storage/replenishment/reordering_rules.rst

+     Procurement groups link replenishment methods to demand, enabling smart buttons to appear when
+     using the :ref:`MTO route <inventory/warehouse_storage/mto-route>`.
+
+     .. figure:: reordering_rules/po-smartbutton.png


I don't see the words 'Procurement Group' anywhere in this image. A little confused what I am looking at.

benderliz

Finally done! Sorry I had to group these comments separately. (I hit a keystroke that made it look like I lost my previous comments, but I still saw the 'Finished your review' button, so I hit it to make sure they weren't lost.)

GREAT JOB, Felicia! There was a lot in this PR, and you handled it all very gracefully! After taking a look, this is fine to pass to technical review.

...plications/inventory_and_mrp/inventory/warehouses_storage/replenishment/reordering_rules.rst

benderliz · 2025-01-30T19:37:39Z

...plications/inventory_and_mrp/inventory/warehouses_storage/replenishment/reordering_rules.rst

+This is achieved using the :ref:`forecasted date <inventory/warehouses_storage/forecasted-date>`,
+which determines when replenishment is necessary to avoid overstocking.
+
+The :ref:`forecasted date <inventory/warehouses_storage/forecasted-date>` is the **earliest possible


I think the ref could be deleted here, since it's included in the previous sentence.

benderliz · 2025-01-30T19:38:12Z

...plications/inventory_and_mrp/inventory/warehouses_storage/replenishment/reordering_rules.rst

+date** to receive a product if the replenishment process starts immediately. It is calculated by
+summing the lead times linked to the replenishment process, such as :ref:`vendor lead times
+<inventory/management/purchase-lt>` and :ref:`purchasing delays
+<inventory/management/purchase-security-lt>` for purchases, or manufacturing lead times for


Consider adding a :ref: for manufacturing lead times.

benderliz · 2025-01-30T19:45:09Z

...plications/inventory_and_mrp/inventory/warehouses_storage/replenishment/reordering_rules.rst

 .. example::
-   A product has a manual reordering rule set to trigger when the stock level falls below four
-   units. The current on-hand quantity is ten units.
+   For a product with a 5-day total lead time and a sales order delivery date in 10 days, Odoo waits


Clear, easy-to-understand example!

...plications/inventory_and_mrp/inventory/warehouses_storage/replenishment/reordering_rules.rst

benderliz · 2025-01-30T21:26:39Z

...plications/inventory_and_mrp/inventory/warehouses_storage/replenishment/reordering_rules.rst

+   The forecasted date is never pushed forward or extended; only if the stock at the forecasted date
+   arrives below the minimum threshold is when Odoo checks the extra visibility days.
+
+Example where visibility days is triggered


This example is SO helpful! Great job!! Do you think it should be in an .. example:: block instead?

content/applications/inventory_and_mrp/inventory/warehouses_storage/replenishment.rst

...plications/inventory_and_mrp/inventory/warehouses_storage/replenishment/reordering_rules.rst

Felicious · 2025-01-31T01:23:12Z

HI @samueljlieber ! This PR is ready for tech review (:

samueljlieber

Hi @Felicious! This PR looks great to me! Fantastic job on this huge lift. I have just a couple quick comments for your consideration, otherwise this is good to go! I anticipate a couple conflicts with the FWPs, so please let me know if you want any help resolving them. Thank you for your hard work! 🚀
.....
@robodoo delegate=Felicious

content/applications/inventory_and_mrp/inventory/warehouses_storage/replenishment.rst

...plications/inventory_and_mrp/inventory/warehouses_storage/replenishment/reordering_rules.rst

Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com> Co-authored-by: Liz Bender <92882399+benderliz@users.noreply.github.com>

Felicious · 2025-02-05T02:44:01Z

@robodoo r+

closes #11444 Signed-off-by: Felicia Kuan (feku) <feku@odoo.com> Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com> Co-authored-by: Liz Bender <92882399+benderliz@users.noreply.github.com>

Felicious added the 2 label Nov 22, 2024

Felicious requested a review from crl-odoo November 22, 2024 01:38

Felicious self-assigned this Nov 22, 2024

Felicious requested a review from hojo-odoo November 22, 2024 01:39

C3POdoo requested a review from a team November 22, 2024 01:40

Felicious marked this pull request as draft November 22, 2024 14:41

Felicious marked this pull request as ready for review November 27, 2024 03:33

Felicious force-pushed the 16.0-inventory-fix-visibility-days-feku branch from 3ac0dbd to e75a8dd Compare November 27, 2024 03:45

Felicious added 16.0 17.0 5 18.0 and removed 2 labels Nov 27, 2024

Felicious force-pushed the 16.0-inventory-fix-visibility-days-feku branch from e75a8dd to 4fbb71e Compare January 8, 2025 02:44

Felicious changed the title ~~[IMP] inventory: fix visibility days~~ [IMP] inventory: rework replenishment + visibility days Jan 8, 2025

Felicious force-pushed the 16.0-inventory-fix-visibility-days-feku branch from 4fbb71e to 80b4362 Compare January 24, 2025 07:02

Felicious removed the request for review from hojo-odoo January 24, 2025 07:33

Felicious force-pushed the 16.0-inventory-fix-visibility-days-feku branch 2 times, most recently from 72f8e0c to facaf62 Compare January 24, 2025 18:13

Felicious changed the title ~~[IMP] inventory: rework replenishment + visibility days~~ [IMP] inventory: CRL - replenishment & visibility days Jan 24, 2025

samueljlieber reviewed Jan 24, 2025

View reviewed changes

Felicious force-pushed the 16.0-inventory-fix-visibility-days-feku branch 2 times, most recently from 58e09f9 to d4c4ca5 Compare January 29, 2025 00:17

benderliz approved these changes Jan 30, 2025

View reviewed changes

benderliz reviewed Jan 30, 2025

View reviewed changes

benderliz approved these changes Jan 30, 2025

View reviewed changes

Felicious commented Jan 31, 2025

View reviewed changes

content/applications/inventory_and_mrp/inventory/warehouses_storage/replenishment.rst Outdated Show resolved Hide resolved

Felicious commented Jan 31, 2025

View reviewed changes

content/applications/inventory_and_mrp/inventory/warehouses_storage/replenishment.rst Outdated Show resolved Hide resolved

Felicious commented Jan 31, 2025

View reviewed changes

content/applications/inventory_and_mrp/inventory/warehouses_storage/replenishment.rst Outdated Show resolved Hide resolved

Felicious commented Jan 31, 2025

View reviewed changes

content/applications/inventory_and_mrp/inventory/warehouses_storage/replenishment.rst Outdated Show resolved Hide resolved

Felicious commented Jan 31, 2025

View reviewed changes

content/applications/inventory_and_mrp/inventory/warehouses_storage/replenishment.rst Show resolved Hide resolved

Felicious commented Jan 31, 2025

View reviewed changes

...plications/inventory_and_mrp/inventory/warehouses_storage/replenishment/reordering_rules.rst Outdated Show resolved Hide resolved

Felicious commented Jan 31, 2025

View reviewed changes

...plications/inventory_and_mrp/inventory/warehouses_storage/replenishment/reordering_rules.rst Outdated Show resolved Hide resolved

Felicious commented Jan 31, 2025

View reviewed changes

...plications/inventory_and_mrp/inventory/warehouses_storage/replenishment/reordering_rules.rst Outdated Show resolved Hide resolved

Felicious commented Jan 31, 2025

View reviewed changes

...plications/inventory_and_mrp/inventory/warehouses_storage/replenishment/reordering_rules.rst Outdated Show resolved Hide resolved

Felicious commented Jan 31, 2025

View reviewed changes

...plications/inventory_and_mrp/inventory/warehouses_storage/replenishment/reordering_rules.rst Outdated Show resolved Hide resolved

Felicious force-pushed the 16.0-inventory-fix-visibility-days-feku branch from c8dac20 to 9ca2924 Compare January 31, 2025 01:11

Felicious requested a review from samueljlieber January 31, 2025 01:23

samueljlieber approved these changes Jan 31, 2025

View reviewed changes

[IMP] inventory: CRL - replenishment & visibility days

5b3604f

Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com> Co-authored-by: Liz Bender <92882399+benderliz@users.noreply.github.com>

Felicious force-pushed the 16.0-inventory-fix-visibility-days-feku branch from 9adf17a to 5b3604f Compare February 5, 2025 02:18

robodoo temporarily deployed to merge February 5, 2025 03:47 Inactive

robodoo closed this Feb 5, 2025

[IMP] inventory: CRL - replenishment & visibility days #11444

[IMP] inventory: CRL - replenishment & visibility days #11444

Uh oh!

Conversation

Felicious commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robodoo commented Nov 22, 2024

Uh oh!

Felicious commented Nov 22, 2024

Uh oh!

Felicious commented Nov 27, 2024

Uh oh!

Felicious commented Jan 8, 2025

Uh oh!

Felicious commented Jan 24, 2025

Uh oh!

Felicious commented Jan 24, 2025

Uh oh!

samueljlieber left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Felicious commented Jan 29, 2025

Uh oh!

benderliz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

benderliz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Felicious commented Nov 22, 2024 •

edited

Loading