[IMP] Sales: Invoicing policy page rewrite #15647
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
Collaborator
Author
|
This PR targets 18.0 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Collaborator
Author
|
@theRealThagomizer ci/documentation failed on this forward-port PR |
X-original-commit: 04e96e0 Co-authored-by: Lara Martini <larm@odoo.com> Co-authored-by: Felicia Kuan <feku@odoo.com> Co-authored-by: Niki Brown <nikbr@odoo.com>
theRealThagomizer
force-pushed
the
18.0-17.0-sales-invoicing-policy-clarification-thjud-480467-fw
branch
from
c5fa2d5 to
eaa3fe0
Compare
Collaborator
Author
|
@theRealThagomizer this PR has become a normal PR because head updated from c5fa2d5 to eaa3fe0. It must be merged be forward-ported further. |
Contributor
|
@Felicious Hiya! Looks like the quotations filepath changed between 17 and 18, so this broke during the forwarding. I fixed the issue, but I think I need approval again to continue the forwarding. |
Contributor
|
@theRealThagomizer i dont think there will be issues. Try @robodoo r+ (: |
Contributor
|
@robodoo r+ |
1 similar comment
Contributor
|
@robodoo r+ |
Collaborator
|
This PR is already reviewed, reviewing it again is useless. |
This was referenced Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Lara! I hope you and your family have/had a wonderful holiday weekend. I've got a super minor PR here that adds a sentence clarifying how the nature of the Invoicing Policy setting works, per this task: https://www.odoo.com/odoo/action-4043/3705841. I also cleaned up the the align:center tags while I was in there. I'm anticipating some merge conflicts further down the line this one, since I think both Megan and I have worked on the invoicing policy page in the past few weeks. Thank you!
This 17.0 PR can be FWP up to master.
Forward-Port-Of: #15499