Skip to content

[IMP] l10n_hk_payroll: update documentation for Hong Kong localization#16581

Closed
kidoodoo wants to merge 1 commit into19.0from
19.0-hk-payroll-kido
Closed

[IMP] l10n_hk_payroll: update documentation for Hong Kong localization#16581
kidoodoo wants to merge 1 commit into19.0from
19.0-hk-payroll-kido

Conversation

@kidoodoo
Copy link
Copy Markdown
Contributor

@kidoodoo kidoodoo commented Feb 27, 2026 •
edited
Loading

  • Document general settings, salary rules, and eMPF schemes
  • Provide step-by-step instructions for employee setup and pay runs
  • Detail accounting checks, payment registration, and IR56 reporting
  • Include calculation examples (ADW, LSP, SP) with formatting

Entire revamp as per the changes made in V19.0

@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented Feb 27, 2026

Pull request status dashboard

@kidoodoo kidoodoo changed the title [ADD] payroll: add documentation for Hong Kong localization [IMP] payroll: add documentation for Hong Kong localization Feb 27, 2026
@kidoodoo kidoodoo changed the title [IMP] payroll: add documentation for Hong Kong localization [IMP] l10n_hk_payroll: add documentation for Hong Kong localization Feb 27, 2026
@kidoodoo kidoodoo force-pushed the 19.0-hk-payroll-kido branch 5 times, most recently from 1bb183a to 17ce3d5 Compare March 2, 2026 11:11
@kidoodoo kidoodoo changed the title [IMP] l10n_hk_payroll: add documentation for Hong Kong localization [IMP] l10n_hk_payroll: update documentation for Hong Kong localization Mar 2, 2026
@kidoodoo kidoodoo force-pushed the 19.0-hk-payroll-kido branch from 17ce3d5 to 38b4f2d Compare March 3, 2026 02:50
@kidoodoo kidoodoo marked this pull request as ready for review March 3, 2026 03:04
@C3POdoo C3POdoo requested review from a team March 3, 2026 03:06
@kidoodoo
Copy link
Copy Markdown
Contributor Author

kidoodoo commented Mar 3, 2026 •
edited
Loading

Hello @larm-odoo !

It has been a while since we last talked, hope you are well :)
Since then, there were a lot of changes in HK payroll to make it more compliance and improve the functionality so that it is actually usable. Accordingly, we decided to revamp the entire page.

@nilar-human worked on the feature and the doc, I simply helped the conversion to .rst.

Since this is our first work on payroll doc, we foresee quite a lot changes requested and feedbacks. Please do not hesitate to let us know for any info.

Thank you :)

@kidoodoo kidoodoo requested a review from larm-odoo March 4, 2026 00:24
@afma-odoo afma-odoo requested review from afma-odoo and removed request for a team March 4, 2026 09:46
larm-odoo
larm-odoo approved these changes Apr 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@larm-odoo larm-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @kidoodoo - this is a great doc with a LOT of information!

I did have an organizational comment (moving the Settings stuff ot that section and out of Payroll), and to not repeat info that is generic payroll info found in other docs. You can always link to other docs/sections of other docs. This helps us avoid outdated info in multiple places.

Basically, everything in this doc should be for Hong Kong only - anything universal should be omitted. I believe you can handle the changes easily - so I am approving now. Thank you for all this hard work!!!!

Comment thread content/applications/finance/fiscal_localizations/hong_kong.rst Outdated
Comment thread content/applications/hr/payroll/payroll_localizations/hong_kong.rst
Comment thread content/applications/hr/payroll/payroll_localizations/hong_kong.rst Outdated
Comment thread content/applications/hr/payroll/payroll_localizations/hong_kong.rst Outdated
Comment thread content/applications/hr/payroll/payroll_localizations/hong_kong.rst Outdated
Comment thread content/applications/hr/payroll/payroll_localizations/hong_kong.rst
Comment thread content/applications/hr/payroll/payroll_localizations/hong_kong.rst Outdated
Comment thread content/applications/hr/payroll/payroll_localizations/hong_kong.rst Outdated
@kidoodoo kidoodoo force-pushed the 19.0-hk-payroll-kido branch from 38b4f2d to e70af46 Compare April 23, 2026 05:33
@kidoodoo
Copy link
Copy Markdown
Contributor Author

kidoodoo commented Apr 23, 2026

Thank you @larm-odoo !

I updated (Removed the part that is standard, not HK specific and updated the image). Could you let me know if further changes are needed?

Have a great day ahead :)

@larm-odoo
Copy link
Copy Markdown
Contributor

larm-odoo commented Apr 23, 2026

This looks great @kidoodoo! Before you merge, please check the bank account image you have. I see there are numbers that appear - if these are "real-looking" numbers, I recommend blurring them out, or half of the number, or something. Just because it looks like real information. Other than that, this is approved! Great job, this was so much work!

@kidoodoo kidoodoo force-pushed the 19.0-hk-payroll-kido branch from e70af46 to 84c2637 Compare April 24, 2026 02:05
@kidoodoo
[IMP] l10n_hk_payroll: add documentation for Hong Kong localization
c6f7fd9 
- Update `hong_kong.rst` page for HK payroll localization as per the recent improvements and changes
- Document general setup, salary rules, and MPF schemes
- Add step-by-step guides for employee configuration and pay runs
- Include mathematical formulas for ADW, SP, and LSP calculations
- Add external links for Employment Ordinance and IRD
@kidoodoo kidoodoo force-pushed the 19.0-hk-payroll-kido branch from 84c2637 to c6f7fd9 Compare April 24, 2026 05:42
@kidoodoo
Copy link
Copy Markdown
Contributor Author

kidoodoo commented Apr 24, 2026

Hello @larm-odoo !
Thank you so much! I made sure all the numbers that look seemingly real are not fully displayed.

Would you be able to r+ or should I be pinging someone else for it?

Thank you :) Wish you a great rest of the week

@larm-odoo larm-odoo added the 5 label Apr 24, 2026
@larm-odoo
Copy link
Copy Markdown
Contributor

larm-odoo commented Apr 24, 2026

@robodoo r+

@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented Apr 24, 2026

@larm-odoo you can't review+.

@larm-odoo
Copy link
Copy Markdown
Contributor

larm-odoo commented Apr 24, 2026

@kidoodoo - thank YOU for all your hard work! I will get this merged, have a wonderful Friday and weekend! =)

@nikibrown
Copy link
Copy Markdown
Contributor

nikibrown commented Apr 24, 2026

@robodoo delegate+

@larm-odoo
Copy link
Copy Markdown
Contributor

larm-odoo commented Apr 24, 2026

@robodoo r+

@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented Apr 24, 2026

@larm-odoo you can't review+.

@Felicious
Copy link
Copy Markdown
Contributor

Felicious commented Apr 24, 2026

@robodoo r+

robodoo pushed a commit that referenced this pull request Apr 24, 2026
@kidoodoo
[IMP] l10n_hk_payroll: add documentation for Hong Kong localization
9c70546 
- Update `hong_kong.rst` page for HK payroll localization as per the recent improvements and changes
- Document general setup, salary rules, and MPF schemes
- Add step-by-step guides for employee configuration and pay runs
- Include mathematical formulas for ADW, SP, and LSP calculations
- Add external links for Employment Ordinance and IRD

closes #16581

Signed-off-by: Felicia Kuan (feku) <feku@odoo.com>
@robodoo robodoo closed this in 07a48a7 Apr 24, 2026
This was referenced Apr 24, 2026
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larm-odoo larm-odoo larm-odoo approved these changes

@afma-odoo afma-odoo Awaiting requested review from afma-odoo

Assignees

@kidoodoo kidoodoo

Labels

5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kidoodoo @robodoo @larm-odoo @nikibrown @Felicious