Skip to content

[IMP] inventory: replace purchase/manufacturing lead times with horizon days#16985

Closed
huisit wants to merge 1 commit into19.0from
19.0-inventory-replace-security-lead-times-with-horizon-days-rexhu
Closed

[IMP] inventory: replace purchase/manufacturing lead times with horizon days#16985
huisit wants to merge 1 commit into19.0from
19.0-inventory-replace-security-lead-times-with-horizon-days-rexhu

Conversation

@huisit
Copy link
Copy Markdown
Contributor

@huisit huisit commented Mar 19, 2026

documentation task card: https://www.odoo.com/odoo/project.task/6046072

key change:

  • remove references to purchase security, manufacturing security.

misc. changes:

  • update lead time diagrams to reflect removal of purchase/manufacturing security lead times.
  • update text examples to reflect removal of purchase/manufacturing security lead times.
  • replace outdated GUI screenshots.
  • rename & add custom anchors for consistency.
  • add missing anchors to types of lead times section.
  • reorder sections and types of lead times list to reflect order of operations in JIT logic.
  • clarify days to prepare manufacturing order logic, since it doesn't appear in the diagram.

note:

  • although this PR touches a lot of the article, it is not a full article refresh; planning to scope out remaining work next week.

This 19.0 PR can be FWP up to master.

@huisit huisit self-assigned this Mar 19, 2026
@huisit huisit added the 3 label Mar 19, 2026
@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented Mar 19, 2026

Pull request status dashboard

@huisit huisit force-pushed the 19.0-inventory-replace-security-lead-times-with-horizon-days-rexhu branch 3 times, most recently from c9ab801 to 6145801 Compare March 20, 2026 20:50
@huisit huisit marked this pull request as ready for review March 20, 2026 20:51
@huisit
Copy link
Copy Markdown
Contributor Author

huisit commented Mar 20, 2026

@theRealThagomizer this is ready for review!

@C3POdoo C3POdoo requested a review from a team March 20, 2026 20:52
@Felicious Felicious added 5 and removed 3 labels Mar 20, 2026
@Felicious
Copy link
Copy Markdown
Contributor

due to the complexity of the topic, im upping the scope from 3 to 5 even though it's not a full article refresh (:

@huisit huisit force-pushed the 19.0-inventory-replace-security-lead-times-with-horizon-days-rexhu branch from 6145801 to df742aa Compare March 21, 2026 00:13
@C3POdoo C3POdoo requested a review from a team March 21, 2026 00:15
Copy link
Copy Markdown
Contributor

@theRealThagomizer theRealThagomizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete! I think the image files might all need to get compressed; they look a bit big and at least one is too large width-wise. I left some comments throughout about commas, but those can be considered stylistic. Nothing looked like it needed a rewrite, so once you double-check the images and decide which commas to keep and which to remove, this is ready to move on!

@huisit huisit force-pushed the 19.0-inventory-replace-security-lead-times-with-horizon-days-rexhu branch 2 times, most recently from 453925a to b98dd14 Compare March 24, 2026 17:29
@huisit
Copy link
Copy Markdown
Contributor Author

huisit commented Mar 24, 2026

Thanks for catching that @theRealThagomizer 🙏
@Felicious this is ready for final!

@huisit huisit requested a review from Felicious March 24, 2026 17:46
@huisit huisit force-pushed the 19.0-inventory-replace-security-lead-times-with-horizon-days-rexhu branch from b98dd14 to 5b3dd13 Compare March 24, 2026 17:46
Copy link
Copy Markdown
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with this PR, @huisit !

I can tell you put in a lot of time and effort understanding the nuances of lead times. I pointed out 2 places where I was confused about the lead times functionality. We might have to test it in runbot to confirm. Let's talk about it in person!

…on days

Co-authored-by: theRealThagomizer <96515928+theRealThagomizer@users.noreply.github.com>
@huisit huisit force-pushed the 19.0-inventory-replace-security-lead-times-with-horizon-days-rexhu branch from 5b3dd13 to 18e2663 Compare March 27, 2026 23:10
@huisit huisit requested a review from Felicious March 28, 2026 00:51
Copy link
Copy Markdown
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @huisit ! Great work on this huge and conceptually loaded PR!

Looking forward to your future improvements with the table and possibly the interactive timeline (:

@Felicious
Copy link
Copy Markdown
Contributor

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants