[IMP] sales: add a pdf to a product pdf quote builder#17359
Closed
[IMP] sales: add a pdf to a product pdf quote builder#17359
Conversation
Collaborator
|
|
meval1006
force-pushed
the
18.0-sales-pdf-quote-builder-add-pdf-to-products-meval
branch
from
9bc63f3 to
a29d079
Compare
huisit
approved these changes
Apr 14, 2026
Contributor
huisit
left a comment
huisit
left a comment
There was a problem hiding this comment.
@meval1006 LGTM! Just a few reminders:
- Use the app name for custom anchors -- I believe the RST guidelines say "app/section name" because of the General settings articles.
- Consider formatting form fields as a bulleted/numbered list so it's easier to scan and see all fields at a glance.
- Make sure to emphasize the difference between template/variant to avoid confusion, since it doesn't appear very frequently in the GUI
meval1006
force-pushed
the
18.0-sales-pdf-quote-builder-add-pdf-to-products-meval
branch
from
8fda82a to
5a2832b
Compare
Co-authored-by: Rex <11528309+huisit@users.noreply.github.com> Co-authored-by: Rex <11528309+huisit@users.noreply.github.com> Co-authored-by: Rex <11528309+huisit@users.noreply.github.com> Co-authored-by: Rex <11528309+huisit@users.noreply.github.com>
meval1006
force-pushed
the
18.0-sales-pdf-quote-builder-add-pdf-to-products-meval
branch
from
5a2832b to
fbe593f
Compare
Contributor
Author
|
Hi @Felicious, this document is ready to review. I bumped it from a 3 to a five because it was restructured and added a lot of content to the existing document. Feel free to bump it down to a 3 if you think it doesn't qualify. |
Felicious
approved these changes
Apr 15, 2026
Contributor
Felicious
left a comment
Felicious
left a comment
There was a problem hiding this comment.
Great work here, @meval1006 !
@robodoo r+
robodoo
pushed a commit
that referenced
this pull request
Apr 15, 2026
closes #17359 Signed-off-by: Felicia Kuan (feku) <feku@odoo.com> Co-authored-by: Rex <11528309+huisit@users.noreply.github.com> Co-authored-by: Rex <11528309+huisit@users.noreply.github.com> Co-authored-by: Rex <11528309+huisit@users.noreply.github.com> Co-authored-by: Rex <11528309+huisit@users.noreply.github.com>
This was referenced Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the Add a PDF to a product page by:
This 18.0 PR can be FWP up to master.