[IMP] us localization: update configuration and profit loss statement#17439
[IMP] us localization: update configuration and profit loss statement#17439
Conversation
|
|
|
@theRealThagomizer this is ready for review when you have a moment! i would love feedback on the |
theRealThagomizer
left a comment
theRealThagomizer
left a comment
There was a problem hiding this comment.
Looks good, @huisit! I had two style comments that you can noodle on and decide whether or not you want to implement them, and one call out for using sentence case in lists. Tweak the sentence cases and do some noodling and you're good to go!
| * - Standard P&L Statement | ||
| - US P&L Statement | ||
| * - Revenue | ||
| - Income | ||
| * - Less Costs of Revenue | ||
| - Cost of Sales | ||
| * - Gross Profit | ||
| - Gross Profit | ||
| * - Less Operating Expenses | ||
| - Expense | ||
| * - Operating Income (or Loss) | ||
| - Net Operating Income | ||
| * - Plus Other Income | ||
| - Other Income | ||
| * - Less Other Expenses | ||
| - Other Expense | ||
| * - | ||
| - Net Other Income | ||
| * - Net Profit | ||
| - Net Income | ||
| * - Less Allocations and Plus Withdrawals | ||
| - | ||
| * - Net Profit Left After Allocations and Withdrawals | ||
| - |
There was a problem hiding this comment.
Worth calling out a blank field with Not applicable or something similar? My knowledge of the nitty gritty of how screenreaders read HTML isn't as good as my knowledge of general principles, but I think it might not indicate an empty cell in a table if it's just identifying the table by the header and reading its contents L-R, T-B.
There was a problem hiding this comment.
I'm also curious about the blank lines from a user POV:
A) Does Less Other Expenses = Other Expense + Net Other Income ?
B) Do the Less Allocations and Plus Withdrawals and Net Profit Left After Allocations and Withdrawals just not exist in the US report?
There was a problem hiding this comment.
Thanks for all your inputs @dade-odoo. Responding to your questions.
A) Less Other Expense pulls all accounts that are of type 'Depreciation' and 'Other Expense'.
In the US, this is simply called Other Expense.
B) That's correct. In European accounting frameworks, the Profit & Loss doesn’t always stop at Net Profit. It can extend into appropriation of profit. Basically, what you do with the profit after it’s earned. Under US GAAP, the P&L is strictly about performance, not appropriation, and hence the report ends at Net Income.
cc- @huisit
There was a problem hiding this comment.
thanks for all of the clarifying questions and information everyone! i updated the table and added a note explaining these discrepancies
| * - Standard P&L Statement | ||
| - US P&L Statement | ||
| * - Revenue | ||
| - Income | ||
| * - Less Costs of Revenue | ||
| - Cost of Sales | ||
| * - Gross Profit | ||
| - Gross Profit | ||
| * - Less Operating Expenses | ||
| - Expense | ||
| * - Operating Income (or Loss) | ||
| - Net Operating Income | ||
| * - Plus Other Income | ||
| - Other Income | ||
| * - Less Other Expenses | ||
| - Other Expense | ||
| * - | ||
| - Net Other Income | ||
| * - Net Profit | ||
| - Net Income | ||
| * - Less Allocations and Plus Withdrawals | ||
| - | ||
| * - Net Profit Left After Allocations and Withdrawals | ||
| - |
There was a problem hiding this comment.
I'm also curious about the blank lines from a user POV:
A) Does Less Other Expenses = Other Expense + Net Other Income ?
B) Do the Less Allocations and Plus Withdrawals and Net Profit Left After Allocations and Withdrawals just not exist in the US report?
huisit
force-pushed
the
19.0-us-localization-config-profit-loss-report-rexhu
branch
from
dc5de83 to
aff2143
Compare
|
@dade-odoo @theRealThagomizer thank you for the reviews! I'm still trying to get clarification from experts about the blank lines/discrepancies, but I just pushed the other changes for now. |
huisit
force-pushed
the
19.0-us-localization-config-profit-loss-report-rexhu
branch
from
aff2143 to
52c59d1
Compare
|
@Felicious this is ready for final! |
huisit
force-pushed
the
19.0-us-localization-config-profit-loss-report-rexhu
branch
from
52c59d1 to
8178bd9
Compare
huisit
force-pushed
the
19.0-us-localization-config-profit-loss-report-rexhu
branch
from
8178bd9 to
5b8c1ec
Compare
|
@robodoo r+ |
6 participants
documentation task card: https://www.odoo.com/odoo/project.task/6104190
key changes:
united statespackagenote: lara will be updating chart of accounts after this merges
This 19.0 PR can be FWP up to master.