[IMP] pos: add tip usable decimal separator #1783
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jcs-odoo
requested changes
Mar 30, 2022
Contributor
jcs-odoo
left a comment
jcs-odoo
left a comment
There was a problem hiding this comment.
This tip is truly amazing! :D
for the commit message, no need to indicate the category before the :
You can also add a comment (like you did for the PR) in the commit message, and ideally with the Odoo task number (that you can find in the task's URL). Just add a blank line, then your text.
Also, commit messages should have lines of 70 characters max (this is just a side note for you)
suggestion:
[IMP] pos: add tip about decimal separators
This commit adds a tip on what decimal separator one can use when
entering an amount.
task-id 2608735
And finally, you can copy-paste the Odoo task URL in the Pull Request's first message, so that reviewers can quickly find the task to update its stage and status :)
Thanks @LoredanaLrpz !
Comment on lines
81
to
82
| .. tip:: | ||
| You can use both `,` and `.` as decimal separator. |
Contributor
There was a problem hiding this comment.
Suggested change
| .. tip:: | |
| You can use both `,` and `.` as decimal separator. | |
| .. tip:: | |
| You can use both `,` and `.` on your keyboard as decimal separators. |
- on your keyboard
- separators plural?
task-id 2608735
LoredanaLrpz
force-pushed
the
13.0-posregisteramount-lrpz
branch
from
e149785 to
a1783d2
Compare
jcs-odoo
changed the title
Contributor
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 31, 2022
task-id 2608735 closes #1783 Signed-off-by: Castillo Jonathan (jcs) <jcs@odoo.com>
This was referenced Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a tip on what decimal separator one can use when entering an amount
https://www.odoo.com/web#id=2608735&menu_id=4720&cids=1&action=333&active_id=3835&model=project.task&view_type=form