[IMP] finance, *: change the term "acquirer" to "provider" #1981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hote-odoo
force-pushed
the
master-payment_rename_acquirer-hote
branch
from
4fde881 to
29b5081
Compare
chiaraprattico
approved these changes
May 11, 2022
hote-odoo
force-pushed
the
master-payment_rename_acquirer-hote
branch
3 times, most recently
from
ddb7a35 to
588e0ca
Compare
jcs-odoo
requested changes
May 14, 2022
Contributor
jcs-odoo
left a comment
jcs-odoo
left a comment
There was a problem hiding this comment.
Hello @hote-odoo and @chiaraprattico
I haven't reviewed the pr in details but I see plenty of file renaming.
This requires redirections that you can add in the file redirects.txt
Also the commit name should be with the tag [IMP] since I don't think you don't add any new doc.
Also, prefer the preposition "as"
[IMP] payment: rename payment acquirers as providers
Have a good weekend :)
hote-odoo
force-pushed
the
master-payment_rename_acquirer-hote
branch
from
588e0ca to
72fa726
Compare
hote-odoo
changed the title
hote-odoo
force-pushed
the
master-payment_rename_acquirer-hote
branch
from
72fa726 to
3ba7a1d
Compare
toaa-odoo
approved these changes
May 31, 2022
hote-odoo
force-pushed
the
master-payment_rename_acquirer-hote
branch
3 times, most recently
from
cb178a2 to
b4c3da6
Compare
hote-odoo
force-pushed
the
master-payment_rename_acquirer-hote
branch
2 times, most recently
from
e2a4ed0 to
183af5d
Compare
jcs-odoo
requested changes
Aug 31, 2022
Contributor
jcs-odoo
left a comment
jcs-odoo
left a comment
There was a problem hiding this comment.
Hello @toaa-odoo and @hote-odoo ,
Thanks for the contribution.
I spotted a few small things
- wrong sentence case letters instead of capital letters
- missing redirections
- missing replacement of Acquirers in the stripe doc (maybe it's a later addition)
Suggestion to change the file name to "providers" (plural) for e-commerce
Thanks :)
content/applications/finance/payment_providers/amazon_payment_services.rst
Show resolved
Hide resolved
hote-odoo
force-pushed
the
master-payment_rename_acquirer-hote
branch
from
183af5d to
627bdbf
Compare
Feyensv
changed the title
hote-odoo
force-pushed
the
master-payment_rename_acquirer-hote
branch
5 times, most recently
from
a2c3feb to
77b38c5
Compare
jcs-odoo
approved these changes
Sep 7, 2022
hote-odoo
force-pushed
the
master-payment_rename_acquirer-hote
branch
from
77b38c5 to
741d122
Compare
Contributor
|
Just change your commit title and ok for me too =] |
hote-odoo
force-pushed
the
master-payment_rename_acquirer-hote
branch
3 times, most recently
from
a1f2b3e to
13f9460
Compare
Demesmaeker
changed the title
hote-odoo
force-pushed
the
master-payment_rename_acquirer-hote
branch
2 times, most recently
from
f6260f5 to
f161494
Compare
Contributor
|
@robodoo r+ |
Collaborator
|
@hote-odoo @jcs-odoo linked pull request(s) odoo/enterprise#27131, odoo/odoo#90899, odoo/upgrade#3542 not ready. Linked PRs are not staged until all of them are ready. |
Contributor
|
@robodoo delegate+ |
Changing the name of model payment.acquirer to payment.provider and everything that it touches. It is technically incorrect to use the term "acquirer" for systems that only provide a service of payment. After this commit the model payment.acquirer and everything related to it will be renamed to payment.provider. Task - 2842088
hote-odoo
force-pushed
the
master-payment_rename_acquirer-hote
branch
from
f161494 to
1f48ebb
Compare
Collaborator
|
@robodoo r+ |
Collaborator
|
@hote-odoo @Feyensv linked pull request(s) odoo/enterprise#27131, odoo/odoo#90899 not ready. Linked PRs are not staged until all of them are ready. |
robodoo
pushed a commit
that referenced
this pull request
Sep 9, 2022
Changing the name of model payment.acquirer to payment.provider and everything that it touches. It is technically incorrect to use the term "acquirer" for systems that only provide a service of payment. After this commit the model payment.acquirer and everything related to it will be renamed to payment.provider. Task - 2842088 closes #1981 Related: odoo/upgrade#3542 Related: odoo/odoo#90899 Related: odoo/enterprise#27131 Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Sep 9, 2022
Changing the name of model payment.acquirer to payment.provider and everything that it touches. It is technically incorrect to use the term "acquirer" for systems that only provide a service of payment. After this commit the model payment.acquirer and all related to it will be renamed to payment.provider. Task - 2842088 closes #90899 Related: odoo/upgrade#3542 Related: odoo/documentation#1981 Related: odoo/enterprise#27131 Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the name of model payment.acquirer to payment.provider
and everything that it touches. It is technically incorrect to
use the term "acquirer" for systems that only provide a service
of payment.
After this commit the model payment.acquirer and everything
related to it will be renamed to payment.provider.
Task - 2842088
See also: