Skip to content

[ADD] accounting/l10n: new localization page for United Arab Emirates #2510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[ADD] accounting/l10n: new localization page for United Arab Emirates #2510

wants to merge 1 commit into from

Conversation

@jcs-odoo
Copy link
Contributor

@jcs-odoo jcs-odoo commented Jul 20, 2022

task-2906051

@robodoo
Copy link
Collaborator

robodoo commented Jul 20, 2022

Pull request status dashboard.

@jcs-odoo jcs-odoo force-pushed the 15.0-l10n-uae-jcs branch from e91c139 to 5a3b90e Compare July 20, 2022 17:34
@toaa-odoo toaa-odoo self-assigned this Jul 22, 2022
@toaa-odoo toaa-odoo force-pushed the 15.0-l10n-uae-jcs branch 3 times, most recently from 2b0657b to 1d22ad4 Compare July 28, 2022 13:51
@toaa-odoo toaa-odoo assigned chiaraprattico and unassigned Donapi Apr 11, 2023
@toaa-odoo toaa-odoo force-pushed the 15.0-l10n-uae-jcs branch 4 times, most recently from f353340 to 55872e6 Compare April 19, 2023 08:48
@toaa-odoo toaa-odoo marked this pull request as ready for review April 19, 2023 08:49
@C3POdoo C3POdoo requested a review from a team April 19, 2023 08:49
@toaa-odoo toaa-odoo force-pushed the 15.0-l10n-uae-jcs branch 2 times, most recently from 733de51 to 39e3a79 Compare April 19, 2023 09:01
@toaa-odoo toaa-odoo requested review from auva-odoo and removed request for a team April 19, 2023 09:01
auva-odoo
auva-odoo requested changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @toaa-odoo, I'm done with the review! I apologize in advance if some of my comments are particularly stupid; this was a difficult subject for me as a newbie. Anyways, we can talk about it whenerver you are ready :)

@toaa-odoo toaa-odoo force-pushed the 15.0-l10n-uae-jcs branch 2 times, most recently from a4c37be to 41c196c Compare April 20, 2023 08:32
@toaa-odoo toaa-odoo requested a review from auva-odoo April 20, 2023 08:32
auva-odoo
auva-odoo requested changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toaa-odoo just a few more things :)

@toaa-odoo toaa-odoo requested a review from auva-odoo April 20, 2023 09:09
@auva-odoo auva-odoo requested a review from a team April 20, 2023 09:20
xpl-odoo
xpl-odoo requested changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@xpl-odoo xpl-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @toaa-odoo ! Mostly nitpicks as usual. Good job overall :)

I'm pinging you @auva-odoo so you can see what you may have missed - even though some comments are based on personal preferences and not strict doc guidelines or grammar rules ;)

@toaa-odoo toaa-odoo force-pushed the 15.0-l10n-uae-jcs branch from 978392a to d2908ef Compare May 2, 2023 07:45
@toaa-odoo toaa-odoo requested a review from xpl-odoo May 2, 2023 07:46
@jcs-odoo @xpl-odoo
[ADD] UAE localization
0c65bfb 
taskid: 2906051
@xpl-odoo xpl-odoo force-pushed the 15.0-l10n-uae-jcs branch from d2908ef to 0c65bfb Compare May 2, 2023 09:30
@xpl-odoo
Copy link
Contributor

xpl-odoo commented May 2, 2023

@robodoo r+

robodoo pushed a commit that referenced this pull request May 2, 2023
@jcs-odoo @xpl-odoo
[ADD] UAE localization
eea4029 
closes #2510

Taskid: 2906051
Signed-off-by: Platteau Xavier (xpl) <xpl@odoo.com>
@fw-bot fw-bot mentioned this pull request May 2, 2023
Closed
@robodoo robodoo temporarily deployed to merge May 2, 2023 12:10 Inactive
@robodoo robodoo closed this May 2, 2023
This was referenced May 2, 2023
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xpl-odoo xpl-odoo xpl-odoo approved these changes

@auva-odoo auva-odoo auva-odoo approved these changes

+1 more reviewer

@toaa-odoo toaa-odoo toaa-odoo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@chiaraprattico chiaraprattico

@toaa-odoo toaa-odoo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jcs-odoo @robodoo @xpl-odoo @toaa-odoo @auva-odoo @Donapi @chiaraprattico