Skip to content

Conversation

@poma-odoo
Copy link
Contributor

No description provided.

@robodoo
Copy link
Collaborator

robodoo commented Aug 11, 2022

@C3POdoo C3POdoo requested a review from a team August 11, 2022 15:39
Copy link
Contributor

@sdegueldre sdegueldre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes seem fine, not sure about commit conventions on this repo though.

@jcs-odoo
Copy link
Contributor

@poma-odoo @sdegueldre

commit title conventions are here https://github.com/odoo/documentation/blob/15.0/commit_template.txt
Also, as code owner for javascript-doc-review , you have to add odoo/doc-review as the reviewer once you've approved the PR. They'll take care of the merge :)

Copy link
Contributor

@jcs-odoo jcs-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change the commit title (and PR title as well) to something such as

[FIX] dev ref/js framework: typo in registries

@sdegueldre sdegueldre requested a review from a team August 18, 2022 12:13
@Feyensv Feyensv changed the title [fix] small typos [FIX] developer/frontend: small typos Aug 18, 2022
Copy link
Collaborator

@Feyensv Feyensv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo r+ squash

@robodoo
Copy link
Collaborator

robodoo commented Aug 18, 2022

Merge method set to squash.

@robodoo robodoo closed this in d204fe7 Aug 18, 2022
@robodoo robodoo temporarily deployed to merge August 18, 2022 13:25 Inactive
@poma-odoo
Copy link
Contributor Author

please change the commit title (and PR title as well) to something such as

[FIX] dev ref/js framework: typo in registries

I guess it is too late, it is already squashed for good, but I'll keep in mind for the next

@Feyensv
Copy link
Collaborator

Feyensv commented Aug 18, 2022

It's better if it's clean directly, but was faster for us here to directly fix it without requesting/doing a force-push only to update the commit :).
Thanks 👍

robodoo pushed a commit that referenced this pull request Aug 18, 2022
closes #2608

Forward-port-of: #2584
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
robodoo pushed a commit that referenced this pull request Aug 18, 2022
closes #2609

Forward-port-of: #2584
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
robodoo pushed a commit that referenced this pull request Aug 18, 2022
closes #2610

Forward-port-of: #2584
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
robodoo pushed a commit that referenced this pull request Aug 18, 2022
closes #2606

Forward-port-of: #2584
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants