-
Notifications
You must be signed in to change notification settings - Fork 10.8k
[FIX] developer/frontend: small typos #2584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sdegueldre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code changes seem fine, not sure about commit conventions on this repo though.
|
commit title conventions are here https://github.com/odoo/documentation/blob/15.0/commit_template.txt |
jcs-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change the commit title (and PR title as well) to something such as
[FIX] dev ref/js framework: typo in registries
Feyensv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robodoo r+ squash
|
Merge method set to squash. |
I guess it is too late, it is already squashed for good, but I'll keep in mind for the next |
|
It's better if it's clean directly, but was faster for us here to directly fix it without requesting/doing a force-push only to update the commit :). |
No description provided.