[IMP] Inventory: updating second person and images, add clarity #3787

larm-odoo · 2023-03-09T21:17:37Z

Updating images, adding more detail, rewriting to remove the second person.

robodoo · 2023-03-09T21:18:05Z

Pull request status dashboard.

StraubCreative · 2023-04-06T19:43:07Z

@hojo-odoo @Felicious @brse-odoo same here can one of you review and then tag @odoo/us-doc-review ?

Felicious

Hi Lara! This was a really well-written doc 😊

I only have minor suggestions including:

Adding one or two headings so people can skip to sections they're looking for easier
Moving the see also section to when units of measure is mentioned in the text
Changing the external reference from :doc: --> :ref: so the link has a lesser chance of breaking
Adding : in front of an :abbr: tag
Specifying the location of the Detailed operations icon on the product form

content/applications/inventory_and_mrp/inventory/management/products/usage.rst

Felicious

Hi Lara! Just wanted to say it was such an informative read (:

larm-odoo

I agree with all your changes and think they are very helpful to the users- thank you for making this doc better!

Felicious · 2023-04-07T17:16:12Z

@StraubCreative

@hojo-odoo @Felicious @brse-odoo same here can one of you review and then tag @odoo/us-doc-review ?

Reviewed and tagged! (:

ksc-odoo

@larm-odoo Hi There! Just finished my Peer Review of this doc - Great job! If you have any questions or need clarification on anything, don't hesitate to reach out. Thanks!

content/applications/inventory_and_mrp/inventory/barcode/setup/software.rst

content/applications/inventory_and_mrp/inventory/management/products/usage.rst

ksc-odoo

@Felicious just gave this another look - and I totally understand what you mean re: the lengthy example block. I left some feedback, but whatever route you choose, I think it's smart to add this info to the doc. Some users may find it super helpful! Great job! If you have any other questions, or need clarification on anything, just let me know.

content/applications/inventory_and_mrp/inventory/management/products/usage.rst

Felicious · 2023-05-26T00:30:25Z

content/applications/inventory_and_mrp/inventory/management/products/usage.rst

I'm suddenly confused again on why we're putting a guilabel on cm, ft in parantheses. Here's the UI:

Since we're not putting a guilabel on Rope or 16.4, I'm confused again 😅

yea these are the values of inputs (not headings, labels, etc.) so they'd receive single back ticks, not guis

I see - I misunderstood. My point of thinking was I thought these units were selections from the Unit of Measure field on the product form, and not a literal input of text "ft".

Thanks for reminding me, Sam (: You made a good point about checking exactly what the UI displays, so I rewrote the section to match quantities that appears on the product form and PO.

Suggested change

The product, `Rope` has its :guilabel:`Unit of Measure` field set to feet (:guilabel:`ft`) and

its :guilabel:`Purchase UoM` set to centimeters (:guilabel:`cm`). When creating a :abbr:`PO

(Purchase Order)` for the product, the :guilabel:`Purchase UoM (Unit of Measure)`, centimeters

(:guilabel:`cm`), appears on the form to measure the quantity of rope the company buys from the

On the product form for `Rope`, the following fields are set as:

- :guilabel:`Unit of Measure` in `ft` (feet), and

- :guilabel:`Purchase UoM` in `cm` (centimeters).

Because the vendor sells rope in `cm`, the purchase :guilabel:`UoM ` is used to represent the

quantity on the :abbr:`PO (Purchase Order)`.

Felicious · 2023-05-26T00:55:56Z

Hi @samueljlieber ! I know you said I could proceed, but I had one more thing I was slightly confused about, and I wanted to ask you what you thought. So so grateful that you could give this one more look (:

samueljlieber · 2023-05-26T17:01:35Z

Hi @Felicious your changes look good to me! I think the rewording clears things up nicely, thank you for taking the time to do that :)

Felicious · 2023-05-26T17:10:13Z

Hi @StraubCreative! This PR originally written by Lara is ready for your review (:

StraubCreative

Hi @Felicious and @larm-odoo
Nice work.
I have a few changes for your consideration below.
Tag me again when we're ready for another look, thanks!

content/applications/inventory_and_mrp/inventory/management/products/usage.rst

StraubCreative · 2023-05-31T21:17:18Z

content/applications/inventory_and_mrp/inventory/management/products/usage.rst

+-------------------
+
+To view all packagings that have been created, go to :menuselection:`Inventory app --> Configuration
+--> Product Packagings`. Doing so reveals a separate page with a complete list of all packagings


does this "separate page" have a name?
Also, is it a page, or a dashboard?
it's better to be specific on things like this...

content/applications/inventory_and_mrp/inventory/management/products/usage.rst

Felicious · 2023-07-07T23:00:23Z

Wow, I lost track of this doc for a month! Thanks for the initial look and comments, @StraubCreative 😸

I made some changes and this doc is ready for another look! Thank you (:

StraubCreative

Hi @Felicious
Really well written. The examples are great.
Approving with comments for you to optionally address now or later, if you choose.

Run the merge command whenever you're ready

@robodoo delegate=Felicious

content/applications/inventory_and_mrp/inventory/management/products/usage.rst

StraubCreative · 2023-08-08T01:47:02Z

content/applications/inventory_and_mrp/inventory/management/products/usage.rst

+(Sales Order)` line. This opens the :guilabel:`Detailed Operations` window with an editable table to
+specify which products are intended for which package.
+
+.. example::


Can continue to update this example later so it's more specific and sits in order of the instructions. I had to go back/forth a few times...

content/applications/inventory_and_mrp/inventory/management/products/usage.rst

feku-review-add-headings-and-extra-reference Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com> Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com> Co-authored-by: Zachary Straub <zst@odoo.com> add changes

Felicious · 2023-08-08T21:34:31Z

@robodoo r+

feku-review-add-headings-and-extra-reference add changes closes #3787 Signed-off-by: Felicia Kuan (feku) <feku@odoo.com> Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com> Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com> Co-authored-by: Zachary Straub <zst@odoo.com>

larm-odoo assigned samueljlieber and larm-odoo Mar 9, 2023

samueljlieber changed the base branch from 16.0 to 14.0 March 9, 2023 21:21

C3POdoo requested a review from a team March 9, 2023 21:22

Felicious requested changes Apr 6, 2023

View reviewed changes

content/applications/inventory_and_mrp/inventory/management/products/usage.rst Outdated Show resolved Hide resolved

Felicious force-pushed the 14.0-inventory-update-uom-packages-packagings-larm branch from 6b5ad8b to 43886bc Compare April 6, 2023 23:04

Felicious reviewed Apr 6, 2023

View reviewed changes

content/applications/inventory_and_mrp/inventory/management/products/usage.rst Outdated Show resolved Hide resolved

Felicious reviewed Apr 6, 2023

View reviewed changes

content/applications/inventory_and_mrp/inventory/management/products/usage.rst Outdated Show resolved Hide resolved

Felicious reviewed Apr 6, 2023

View reviewed changes

content/applications/inventory_and_mrp/inventory/management/products/usage.rst Outdated Show resolved Hide resolved

Felicious reviewed Apr 6, 2023

View reviewed changes

content/applications/inventory_and_mrp/inventory/management/products/usage.rst Outdated Show resolved Hide resolved

Felicious reviewed Apr 6, 2023

View reviewed changes

Felicious force-pushed the 14.0-inventory-update-uom-packages-packagings-larm branch from 43886bc to 1610ece Compare April 6, 2023 23:17

larm-odoo commented Apr 7, 2023

View reviewed changes

Felicious force-pushed the 14.0-inventory-update-uom-packages-packagings-larm branch from 1610ece to 403615d Compare April 7, 2023 17:09

Felicious approved these changes Apr 7, 2023

View reviewed changes

Felicious force-pushed the 14.0-inventory-update-uom-packages-packagings-larm branch from 403615d to df8f8b8 Compare April 7, 2023 17:13

Felicious requested a review from a team April 7, 2023 17:15

ksc-odoo reviewed Apr 17, 2023

View reviewed changes

Felicious self-assigned this Apr 18, 2023

Felicious force-pushed the 14.0-inventory-update-uom-packages-packagings-larm branch from df8f8b8 to 0ac7730 Compare April 20, 2023 20:29

Felicious reviewed Apr 20, 2023

View reviewed changes

content/applications/inventory_and_mrp/inventory/management/products/usage.rst Outdated Show resolved Hide resolved

Felicious requested a review from ksc-odoo April 20, 2023 20:36

samueljlieber requested a review from a team April 20, 2023 21:25

ksc-odoo reviewed Apr 25, 2023

View reviewed changes

Felicious force-pushed the 14.0-inventory-update-uom-packages-packagings-larm branch 2 times, most recently from a7c0852 to 20c8bde Compare April 26, 2023 18:00

Felicious force-pushed the 14.0-inventory-update-uom-packages-packagings-larm branch from 20c8bde to e2553f4 Compare May 4, 2023 21:05

Felicious reviewed May 26, 2023

View reviewed changes

Felicious force-pushed the 14.0-inventory-update-uom-packages-packagings-larm branch from 1194c17 to e026a63 Compare May 26, 2023 00:54

Felicious requested a review from samueljlieber May 26, 2023 00:55

Felicious force-pushed the 14.0-inventory-update-uom-packages-packagings-larm branch from e026a63 to 64f4661 Compare May 26, 2023 16:54

Felicious force-pushed the 14.0-inventory-update-uom-packages-packagings-larm branch from 64f4661 to 974a693 Compare May 26, 2023 17:08

Felicious requested a review from StraubCreative May 26, 2023 17:10

StraubCreative requested changes May 31, 2023

View reviewed changes

Felicious reviewed Jun 1, 2023

View reviewed changes

content/applications/inventory_and_mrp/inventory/management/products/usage.rst Outdated Show resolved Hide resolved

Felicious force-pushed the 14.0-inventory-update-uom-packages-packagings-larm branch from eadb30a to 86808df Compare July 7, 2023 22:58

Felicious requested a review from StraubCreative July 7, 2023 22:58

StraubCreative approved these changes Aug 8, 2023

View reviewed changes

Felicious reviewed Aug 8, 2023

View reviewed changes

content/applications/inventory_and_mrp/inventory/management/products/usage.rst Outdated Show resolved Hide resolved

Felicious force-pushed the 14.0-inventory-update-uom-packages-packagings-larm branch from 62ae133 to 91ac8bb Compare August 8, 2023 21:30

robodoo temporarily deployed to merge August 8, 2023 22:28 Inactive

fw-bot mentioned this pull request Aug 8, 2023

[FW][IMP] Inventory: updating second person and images, add clarity #5435

Closed

robodoo closed this Aug 8, 2023

-   The product, `Rope` has its :guilabel:`Unit of Measure` field set to feet (:guilabel:`ft`) and
-   its :guilabel:`Purchase UoM` set to centimeters (:guilabel:`cm`). When creating a :abbr:`PO
-   (Purchase Order)` for the product, the :guilabel:`Purchase UoM (Unit of Measure)`, centimeters
-   (:guilabel:`cm`), appears on the form to measure the quantity of rope the company buys from the
+   On the product form for `Rope`, the following fields are set as:
+   - :guilabel:`Unit of Measure` in `ft` (feet), and
+   - :guilabel:`Purchase UoM` in `cm` (centimeters).
+   Because the vendor sells rope in `cm`, the purchase :guilabel:`UoM ` is used to represent the
+   quantity on the :abbr:`PO (Purchase Order)`.

[IMP] Inventory: updating second person and images, add clarity #3787

[IMP] Inventory: updating second person and images, add clarity #3787

Uh oh!

Conversation

larm-odoo commented Mar 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robodoo commented Mar 9, 2023

Uh oh!

StraubCreative commented Apr 6, 2023

Uh oh!

Felicious left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Felicious left a comment

Choose a reason for hiding this comment

Uh oh!

larm-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Felicious commented Apr 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ksc-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ksc-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Felicious May 26, 2023

Choose a reason for hiding this comment

Uh oh!

StraubCreative May 26, 2023

Choose a reason for hiding this comment

Uh oh!

samueljlieber May 26, 2023

Choose a reason for hiding this comment

Uh oh!

Felicious May 26, 2023

Choose a reason for hiding this comment

Uh oh!

Felicious commented May 26, 2023

Uh oh!

samueljlieber commented May 26, 2023

Uh oh!

Felicious commented May 26, 2023

Uh oh!

StraubCreative left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

larm-odoo commented Mar 9, 2023 •

edited

Loading

Felicious commented Apr 7, 2023 •

edited

Loading

StraubCreative left a comment •

edited

Loading