-
Notifications
You must be signed in to change notification settings - Fork 10.7k
[ADD] Inventory: Use locations to manage inventory #3843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey @StraubCreative, This PR is ready for review. Thanks, |
samueljlieber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hojo-odoo 👋 Ive made some technical changes below for your reference. I will push these changes up as a second commit for your review. Please let me know if you approve of the changes and I will squash the commits, rebase and push back up for final review.
The changes were on correct media filenames, using italics, using :menuselection:, and indenting text in admonition blocks.
Overall, the doc reads well and you provide a solid example of creating location hierarchies 🙂
content/applications/inventory_and_mrp/inventory/management/warehouses/use_locations.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/warehouses/use_locations.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/warehouses/use_locations.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/warehouses/use_locations.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/warehouses/use_locations.rst
Outdated
Show resolved
Hide resolved
0f922cf to
eda5213
Compare
eda5213 to
efbf2d7
Compare
|
Fixed merge conflict in efbf2d7. |
|
Kicking back to you @samueljlieber please solve the merge conflict with HOJO and give the doc another pass (seemed ok on quick glance but you never know 😉 ) |
efbf2d7 to
bc581a4
Compare
samueljlieber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hojo-odoo 👋 just a few very small technical changes to this PR, please review my suggestion and let me know if you have any other questions, otherwise I look forward to seeing your changes. Thank you!
content/applications/inventory_and_mrp/inventory/management/warehouses/use_locations.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/warehouses/use_locations.rst
Outdated
Show resolved
Hide resolved
c777c8e to
c71e9c0
Compare
samueljlieber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hojo-odoo, I caught a couple more changes here. I will push up a commit after this review and approve.
content/applications/inventory_and_mrp/inventory/management/warehouses/use_locations.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/warehouses/use_locations.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/warehouses/use_locations.rst
Outdated
Show resolved
Hide resolved
c71e9c0 to
a7a577d
Compare
samueljlieber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @StraubCreative
StraubCreative
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robodoo r+
content/applications/inventory_and_mrp/inventory/routes/strategies/removal.rst
Show resolved
Hide resolved
closes #3843 Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
|
@hojo-odoo @StraubCreative staging failed: ci/template on 92df0585294f41c1b8c5577205b4286296753f44 (view more at https://runbot.odoo.com/runbot/build/53572939) |
|
@robodoo retry |
closes #3843 Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
This PR adds a new doc about how to create locations and location hierarchies.