Skip to content

Conversation

@hojo-odoo
Copy link
Contributor

This PR adds a new doc about how to create locations and location hierarchies.

@robodoo
Copy link
Collaborator

robodoo commented Mar 16, 2023

@C3POdoo C3POdoo requested a review from a team March 16, 2023 22:35
@hojo-odoo
Copy link
Contributor Author

Hey @StraubCreative,

This PR is ready for review.

Thanks,
hojo

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hojo-odoo 👋 Ive made some technical changes below for your reference. I will push these changes up as a second commit for your review. Please let me know if you approve of the changes and I will squash the commits, rebase and push back up for final review.

The changes were on correct media filenames, using italics, using :menuselection:, and indenting text in admonition blocks.

Overall, the doc reads well and you provide a solid example of creating location hierarchies 🙂

@samueljlieber samueljlieber force-pushed the 14.0-inventory-add-use-locations-hojo branch from 0f922cf to eda5213 Compare March 29, 2023 14:30
@samueljlieber samueljlieber force-pushed the 14.0-inventory-add-use-locations-hojo branch from eda5213 to efbf2d7 Compare April 18, 2023 19:58
@samueljlieber
Copy link
Contributor

Fixed merge conflict in efbf2d7.

@StraubCreative StraubCreative requested review from samueljlieber and removed request for StraubCreative May 5, 2023 00:40
@StraubCreative
Copy link
Contributor

Kicking back to you @samueljlieber please solve the merge conflict with HOJO and give the doc another pass (seemed ok on quick glance but you never know 😉 )

@samueljlieber samueljlieber force-pushed the 14.0-inventory-add-use-locations-hojo branch from efbf2d7 to bc581a4 Compare May 9, 2023 18:33
@samueljlieber
Copy link
Contributor

Fixed merge conflict in bc581a4 due to 9b04ed1.

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hojo-odoo 👋 just a few very small technical changes to this PR, please review my suggestion and let me know if you have any other questions, otherwise I look forward to seeing your changes. Thank you!

@hojo-odoo hojo-odoo force-pushed the 14.0-inventory-add-use-locations-hojo branch 2 times, most recently from c777c8e to c71e9c0 Compare November 9, 2023 18:43
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hojo-odoo, I caught a couple more changes here. I will push up a commit after this review and approve.

@samueljlieber samueljlieber force-pushed the 14.0-inventory-add-use-locations-hojo branch from c71e9c0 to a7a577d Compare November 9, 2023 20:29
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo pushed a commit that referenced this pull request Nov 9, 2023
closes #3843

Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
@robodoo
Copy link
Collaborator

robodoo commented Nov 9, 2023

@hojo-odoo @StraubCreative staging failed: ci/template on 92df0585294f41c1b8c5577205b4286296753f44 (view more at https://runbot.odoo.com/runbot/build/53572939)

@hojo-odoo
Copy link
Contributor Author

@robodoo retry

robodoo pushed a commit that referenced this pull request Nov 10, 2023
closes #3843

Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
@robodoo robodoo closed this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants