[IMP] inventory: flesh out accounting #4005

Felicious · 2023-04-04T00:09:37Z

Revision of Average inventory valuation cost method.
Task ID: #3255051

Summary

Hi! I'm newly assigned to the inventory scope and wanted to update this inventory valuation doc for Odoo 14 and elaborate the accounting concepts in layman's terms. If you are able to fact-check and expand on the accounting concepts, I would greatly appreciate it!

Other changes

Add math formulas to elaborate the journal entry calculations about inventory valuation
Add more headings for organization (because the document got LONG very quickly)
Renamed headings to be action-oriented and sentence case
Add external links to related docs
Remove instances of "I", "our", "we" and other pronouns
Rewritten for clarity (not brevity)

Things to look out for in the review

(in order of importance)

What do you think about the Anglo-Saxon section (lines 186-266)
Does the definition of AVCO make sense?
Are the accounting concepts clear & accurate?
Do math explanations make sense?
Can they be shortened a little?
How is the organization of examples?
Do intros of sections seem redundant?

This PR is intended to be FW ported

robodoo · 2023-04-04T00:10:25Z

Pull request status dashboard.

toaa-odoo

Hi Felicia! Thanks for your tremendous work, this page clearly needed a bit of love. I have yet to investigate the Anglo-Saxon section and see about that $2 difference, but here's what I have to say about the rest of the PR so far :). I'll get back to you when I know better about the right behavior

content/applications/finance/accounting/others/inventory/avg_price_valuation.rst

Felicious · 2023-04-10T05:00:33Z

Hi @toaa-odoo ! Thank you again for a thorough review of this doc. I implemented the changes you suggested.

Additional changes (as of April 10)

Added more details to average cost valuation definition
Some formatting to emphasize credit and debit behaviors
Renamed previously "movie title-like" heading to: Elimate stock valuation errors in outgoing products
Edits to "Anglo Saxon" section-- added headings, more colloquial explanations to accounting behaviors (let me know if you liked the previous version better)

Let me know what you think! (:

Also, since I'm still familiarizing myself with Github, I accidentally removed you as a contributor in the commit message when I was merging the remote branch with my local branch. So, the commit currently isn't showing that you contributed to the doc. (But the changes you suggested are still there) I will work on restoring it another time!

toaa-odoo · 2023-04-11T12:04:43Z

content/applications/finance/accounting/others/inventory/avg_price_valuation.rst

+   #. Debit *stock input* account `$12` (Why?)
+      #. also how to account for the `$2` price difference?


The Stock Input account is debited $12 because the avg cost of a table is 12 at the moment the product is returned (even though it was bought for $10). The $2 price difference has to be accounted for in the Price Difference Account field under the product category. The Price Difference Account differs from localization to localization of course :).

Note that this only works with automated inventory valuation, and it could be interesting to add as note (+ :doc: or :ref: to this page https://www.odoo.com/documentation/16.0/applications/inventory_and_mrp/inventory/management/reporting/inventory_valuation_config.html?highlight=inventory%20valuation)

toaa-odoo

Thanks for the changes @Felicious , see my new comments to know what's left to fix!

content/applications/finance/accounting/others/inventory/avg_price_valuation.rst

Felicious · 2023-04-17T19:28:00Z

Summary of recent edits

4/17/23

Added images of Odoo screenshots to show workflow
Added configuration instructions and descriptions for where to find buttons/menus to use AVCO in Odoo

Concerns:

the length
In what ways can I better use admonition blocks, cards, and other RST tools to help users find the information they need and sift through this long doc?
Thinking about: the flow and presentation of information. ie. Should the theoretical information be hidden using spoiler blocks? Are the charts useful? How about the summary of debit/credit statements?

meng-odoo

Hi @Felicious! Great job on this doc, it's super thorough and well-written! I made suggestions for formatting, content, and wording throughout, which I hope are helpful in shortening the doc and making it a bit more skimmable and understandable for readers. Please let me know if you have any questions!

content/applications/finance/accounting/others/inventory/avg_price_valuation.rst

meng-odoo

Hi @Felicious! This doc is very well written, concise, and easy to follow, and I appreciate you including many links to elsewhere in the doc or to other docs, which makes it super usable for readers skimming :) I had some small additions to make some of the instructions clearer/more detailed, and small typo/formatting fixes. I'm approving now, but please go through those edits before moving this to the next review stage. Thank you!

content/applications/finance/accounting/others/inventory/avg_price_valuation.rst

Co-authored-by: toaa <104567387+toaa-odoo@users.noreply.github.com> Co-authored-by: meng-odoo <101904966+meng-odoo@users.noreply.github.com>

Felicious · 2023-11-10T23:26:25Z

Thank you, @meng-odoo 😄, really appreciate your thorough review! I'm very confident in this doc, now. Passing it over to you, @StraubCreative

StraubCreative

LGTM, all checks pass ✅

Since this has been open for a bit, I'd like to ship live and we can address any changes in a new PR.

Thanks everyone for the detailed work on this!

@robodoo r+

closes #4005 Signed-off-by: Zachary Straub (zst) <zst@odoo.com> Co-authored-by: toaa <104567387+toaa-odoo@users.noreply.github.com> Co-authored-by: meng-odoo <101904966+meng-odoo@users.noreply.github.com>

fw-bot · 2023-11-16T05:54:25Z

@Felicious @StraubCreative this pull request has forward-port PRs awaiting action (not merged or closed):

[FW][IMP] inventory: flesh out accounting #6483

C3POdoo requested review from a team April 4, 2023 00:10

Felicious changed the title ~~[IMP]: flesh out accounting and math~~ [IMP] inventory: flesh out accounting Apr 4, 2023

Felicious removed request for a team April 4, 2023 00:14

Felicious force-pushed the 14.0-inventory-avg-price-val-on-returned-goods-feku branch 3 times, most recently from 17d8b51 to 8904ae9 Compare April 6, 2023 00:01

Felicious requested a review from a team April 6, 2023 00:06

Felicious marked this pull request as draft April 6, 2023 00:06

toaa-odoo reviewed Apr 7, 2023

View reviewed changes

Felicious marked this pull request as ready for review April 7, 2023 18:41

C3POdoo requested review from a team April 7, 2023 18:42

Felicious force-pushed the 14.0-inventory-avg-price-val-on-returned-goods-feku branch 2 times, most recently from 9363ec0 to 76ad9fc Compare April 10, 2023 04:53

Felicious marked this pull request as draft April 10, 2023 05:00

Felicious requested a review from toaa-odoo April 10, 2023 21:07

toaa-odoo removed the request for review from a team April 11, 2023 09:31

toaa-odoo reviewed Apr 11, 2023

View reviewed changes

toaa-odoo suggested changes Apr 11, 2023

View reviewed changes

content/applications/finance/accounting/others/inventory/avg_price_valuation.rst Outdated Show resolved Hide resolved

Felicious force-pushed the 14.0-inventory-avg-price-val-on-returned-goods-feku branch from 76ad9fc to 6616533 Compare April 17, 2023 19:22

Felicious requested a review from hojo-odoo April 17, 2023 19:23

Felicious assigned Felicious and hojo-odoo Apr 17, 2023

Felicious marked this pull request as ready for review April 17, 2023 19:28

C3POdoo requested a review from a team April 17, 2023 19:30

Felicious force-pushed the 14.0-inventory-avg-price-val-on-returned-goods-feku branch from 0a92af1 to 73d42e1 Compare April 19, 2023 01:00

Felicious requested review from a team and removed request for a team and hojo-odoo May 9, 2023 20:43

meng-odoo suggested changes May 18, 2023

View reviewed changes

This comment was marked as duplicate.

Sign in to view

Felicious commented May 18, 2023

View reviewed changes

content/applications/finance/accounting/others/inventory/avg_price_valuation.rst Outdated Show resolved Hide resolved

Felicious force-pushed the 14.0-inventory-avg-price-val-on-returned-goods-feku branch 3 times, most recently from 2340c9f to 84b52a3 Compare November 8, 2023 18:13

Felicious requested a review from meng-odoo November 8, 2023 18:13

meng-odoo approved these changes Nov 10, 2023

View reviewed changes

[IMP] inventory: expand on accounting and math

3efa785

Co-authored-by: toaa <104567387+toaa-odoo@users.noreply.github.com> Co-authored-by: meng-odoo <101904966+meng-odoo@users.noreply.github.com>

Felicious force-pushed the 14.0-inventory-avg-price-val-on-returned-goods-feku branch from 653c8c8 to 3efa785 Compare November 10, 2023 23:23

Felicious requested a review from StraubCreative November 10, 2023 23:26

StraubCreative approved these changes Nov 12, 2023

View reviewed changes

robodoo temporarily deployed to merge November 12, 2023 23:37 Inactive

fw-bot mentioned this pull request Nov 12, 2023

[FW][IMP] inventory: flesh out accounting #6424

Closed

robodoo closed this Nov 12, 2023

		#. Debit stock input account `$12` (Why?)
		#. also how to account for the `$2` price difference?

[IMP] inventory: flesh out accounting #4005

[IMP] inventory: flesh out accounting #4005

Uh oh!

Conversation

Felicious commented Apr 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Things to look out for in the review

Uh oh!

robodoo commented Apr 4, 2023

Uh oh!

toaa-odoo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Felicious commented Apr 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Additional changes (as of April 10)

Uh oh!

toaa-odoo Apr 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

toaa-odoo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Felicious commented Apr 17, 2023

Summary of recent edits

Uh oh!

meng-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as duplicate.

Uh oh!

Uh oh!

meng-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Felicious commented Nov 10, 2023

Uh oh!

StraubCreative left a comment

Choose a reason for hiding this comment

Uh oh!

fw-bot commented Nov 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Felicious commented Apr 4, 2023 •

edited

Loading

toaa-odoo left a comment •

edited

Loading

Felicious commented Apr 10, 2023 •

edited

Loading

toaa-odoo Apr 11, 2023 •

edited

Loading

toaa-odoo left a comment •

edited

Loading