Skip to content

Conversation

@fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Nov 12, 2023

Revision of Average inventory valuation cost method.
Task ID: #3255051

Summary

Hi! I'm newly assigned to the inventory scope and wanted to update this inventory valuation doc for Odoo 14 and elaborate the accounting concepts in layman's terms. If you are able to fact-check and expand on the accounting concepts, I would greatly appreciate it!

Other changes

  • Add math formulas to elaborate the journal entry calculations about inventory valuation
  • Add more headings for organization (because the document got LONG very quickly)
  • Renamed headings to be action-oriented and sentence case
  • Add external links to related docs
  • Remove instances of "I", "our", "we" and other pronouns
  • Rewritten for clarity (not brevity)

Things to look out for in the review

(in order of importance)

  1. What do you think about the Anglo-Saxon section (lines 186-266)
  2. Does the definition of AVCO make sense?
  3. Are the accounting concepts clear & accurate?
  4. Do math explanations make sense?
  5. Can they be shortened a little?
  6. How is the organization of examples?
  7. Do intros of sections seem redundant?

This PR is intended to be FW ported

Forward-Port-Of: #4005

@robodoo
Copy link
Collaborator

robodoo commented Nov 12, 2023

@fw-bot
Copy link
Collaborator Author

fw-bot commented Nov 12, 2023

@Felicious @StraubCreative cherrypicking of pull request #4005 failed.

stdout:

Auto-merging content/applications/finance/accounting/get_started/avg_price_valuation.rst
CONFLICT (content): Merge conflict in content/applications/finance/accounting/get_started/avg_price_valuation.rst
CONFLICT (file location): content/applications/finance/accounting/others/inventory/avg_price_valuation/accounting-entry-8-tables.png added in 3efa785dd ([IMP] inventory: expand on accounting and math) inside a directory that was renamed in HEAD, suggesting it should perhaps be moved to content/applications/finance/accounting/get_started/avg_price_valuation/accounting-entry-8-tables.png.
CONFLICT (rename/delete): content/applications/finance/accounting/others/inventory/avg_price_valuation/avg01.png renamed to content/applications/finance/accounting/get_started/avg_price_valuation/avg01.png in HEAD, but deleted in 3efa785dd ([IMP] inventory: expand on accounting and math).
CONFLICT (file location): content/applications/finance/accounting/others/inventory/avg_price_valuation/create-price-difference.png added in 3efa785dd ([IMP] inventory: expand on accounting and math) inside a directory that was renamed in HEAD, suggesting it should perhaps be moved to content/applications/finance/accounting/get_started/avg_price_valuation/create-price-difference.png.
CONFLICT (file location): content/applications/finance/accounting/others/inventory/avg_price_valuation/expensing-price-difference-account.png added in 3efa785dd ([IMP] inventory: expand on accounting and math) inside a directory that was renamed in HEAD, suggesting it should perhaps be moved to content/applications/finance/accounting/get_started/avg_price_valuation/expensing-price-difference-account.png.
CONFLICT (file location): content/applications/finance/accounting/others/inventory/avg_price_valuation/inventory-val-8-tables.png added in 3efa785dd ([IMP] inventory: expand on accounting and math) inside a directory that was renamed in HEAD, suggesting it should perhaps be moved to content/applications/finance/accounting/get_started/avg_price_valuation/inventory-val-8-tables.png.
CONFLICT (file location): content/applications/finance/accounting/others/inventory/avg_price_valuation/inventory-val-send-10-tables.png added in 3efa785dd ([IMP] inventory: expand on accounting and math) inside a directory that was renamed in HEAD, suggesting it should perhaps be moved to content/applications/finance/accounting/get_started/avg_price_valuation/inventory-val-send-10-tables.png.
CONFLICT (file location): content/applications/finance/accounting/others/inventory/avg_price_valuation/inventory-valuation-return.png added in 3efa785dd ([IMP] inventory: expand on accounting and math) inside a directory that was renamed in HEAD, suggesting it should perhaps be moved to content/applications/finance/accounting/get_started/avg_price_valuation/inventory-valuation-return.png.
CONFLICT (file location): content/applications/finance/accounting/others/inventory/avg_price_valuation/receive-8-table-bill.png added in 3efa785dd ([IMP] inventory: expand on accounting and math) inside a directory that was renamed in HEAD, suggesting it should perhaps be moved to content/applications/finance/accounting/get_started/avg_price_valuation/receive-8-table-bill.png.
CONFLICT (file location): content/applications/finance/accounting/others/inventory/avg_price_valuation/return-credit-note.png added in 3efa785dd ([IMP] inventory: expand on accounting and math) inside a directory that was renamed in HEAD, suggesting it should perhaps be moved to content/applications/finance/accounting/get_started/avg_price_valuation/return-credit-note.png.
CONFLICT (file location): content/applications/finance/accounting/others/inventory/avg_price_valuation/search-for-entry-of-tables.png added in 3efa785dd ([IMP] inventory: expand on accounting and math) inside a directory that was renamed in HEAD, suggesting it should perhaps be moved to content/applications/finance/accounting/get_started/avg_price_valuation/search-for-entry-of-tables.png.
CONFLICT (file location): content/applications/finance/accounting/others/inventory/avg_price_valuation/sell-10-tables.png added in 3efa785dd ([IMP] inventory: expand on accounting and math) inside a directory that was renamed in HEAD, suggesting it should perhaps be moved to content/applications/finance/accounting/get_started/avg_price_valuation/sell-10-tables.png.
Auto-merging content/applications/inventory_and_mrp/inventory/management/reporting/integrating_landed_costs.rst
CONFLICT (content): Merge conflict in content/applications/inventory_and_mrp/inventory/management/reporting/integrating_landed_costs.rst

stderr:

00:37:33.314935 git.c:463               trace: built-in: git cherry-pick 3efa785ddb1373a182d6a82a4251a416ca8e6147
error: could not apply 3efa785dd... [IMP] inventory: expand on accounting and math
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@Felicious Felicious force-pushed the 15.0-14.0-inventory-avg-price-val-on-returned-goods-feku-Qztn-fw branch from 374b3d3 to b534c65 Compare November 13, 2023 19:19
@C3POdoo C3POdoo requested review from a team November 13, 2023 19:21
@Felicious Felicious force-pushed the 15.0-14.0-inventory-avg-price-val-on-returned-goods-feku-Qztn-fw branch from b534c65 to fe48b5c Compare November 13, 2023 19:29
X-original-commit: 058515e
Co-authored-by: toaa <104567387+toaa-odoo@users.noreply.github.com>
Co-authored-by: meng-odoo <101904966+meng-odoo@users.noreply.github.com>
@Felicious Felicious force-pushed the 15.0-14.0-inventory-avg-price-val-on-returned-goods-feku-Qztn-fw branch from fe48b5c to 20bd958 Compare November 13, 2023 20:25
@StraubCreative
Copy link
Contributor

Merge conflict due to restructure in #4422 which affected 15.0 and later.
Should be resolved now and reflected to every FWP past this one...

@robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Nov 13, 2023

@Felicious @StraubCreative staging failed: ci/runbot on 485bf7c620c41e383faaceec78e8c48513baf99d (view more at https://runbot.odoo.com/runbot/build/53661303)

@StraubCreative
Copy link
Contributor

@robodoo retry

robodoo pushed a commit that referenced this pull request Nov 14, 2023
closes #6424

X-original-commit: 058515e
Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
Co-authored-by: toaa <104567387+toaa-odoo@users.noreply.github.com>
Co-authored-by: meng-odoo <101904966+meng-odoo@users.noreply.github.com>
@robodoo
Copy link
Collaborator

robodoo commented Nov 14, 2023

@Felicious @StraubCreative staging failed: ci/runbot on 6dc3c60c3a031e43f2b69fc7e80e4e1740716e19 (view more at https://runbot.odoo.com/runbot/build/53663667)

@StraubCreative
Copy link
Contributor

@robodoo retry

robodoo pushed a commit that referenced this pull request Nov 15, 2023
closes #6424

X-original-commit: 058515e
Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
Co-authored-by: toaa <104567387+toaa-odoo@users.noreply.github.com>
Co-authored-by: meng-odoo <101904966+meng-odoo@users.noreply.github.com>
@robodoo robodoo closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants