-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[ADD] k7e: how to manage articles (add, del, move, structure, share). #4393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @LoredanaLrpz, thanks for your great work! As of right now, I think the structure could be improved.
Create, delete, and share are all ideologically similar and IMO could be grouped together. As of right, the structure goes "Create --> Structure --> Share --> Delete", effectively being cut by "Structure" right in the middle. Additionally, the "Structure" section introduces concepts "Share and access rights" that are explained after the "Structure" section, which is not logical. Finally, the "Creation" section is literally one line. I don't think it warrants a section of its own.
My suggestion would be to create as H2: "Creation, sharing, and deletion of articles" where you would explain how to create, share, and delete articles". That way they're all grouped up together ideologically, the creation section isn't a one-liner, and the "share" and "access rights" concepts are introduced before the "structure" section.
More general comments: lists take a semi-colon after each line ";", and the final line takes a full stop ".". You can find UTF-8 character set shapes (such as the star) pretty quickly on Google, for future docs (and shapes!)
a4b2306 to
cf0d33e
Compare
|
Hey @toaa-odoo , thanks for the previous review --> I'm ready for you to review this again. You'll notice I haven't changed the punctuation in the bulleted list, as it's not grammatically mandatory to do at all (not for complete sentences starting with a capital letter). |
toaa-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, just added a suggestion for the tip
xpl-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 😃
@robodoo delegate+
cf0d33e to
7b3744a
Compare
|
@robodoo r+ |
Task-3049957 closes #4393 Signed-off-by: Perazzo Loredana (lrpz) <lrpz@odoo.com>
|
@LoredanaLrpz this pull request has forward-port PRs awaiting action (not merged or closed): |
Task-3049957
This PR adds a new page about how to manage articles - must be changed in 16.2!