Skip to content

Conversation

@LoredanaLrpz
Copy link
Contributor

Task-3049957

This PR adds a new page about how to manage articles - must be changed in 16.2!

@robodoo
Copy link
Collaborator

robodoo commented May 10, 2023

@LoredanaLrpz LoredanaLrpz requested a review from toaa-odoo May 10, 2023 13:46
@C3POdoo C3POdoo requested a review from a team May 10, 2023 14:00
Copy link
Contributor

@toaa-odoo toaa-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LoredanaLrpz, thanks for your great work! As of right now, I think the structure could be improved.

Create, delete, and share are all ideologically similar and IMO could be grouped together. As of right, the structure goes "Create --> Structure --> Share --> Delete", effectively being cut by "Structure" right in the middle. Additionally, the "Structure" section introduces concepts "Share and access rights" that are explained after the "Structure" section, which is not logical. Finally, the "Creation" section is literally one line. I don't think it warrants a section of its own.

My suggestion would be to create as H2: "Creation, sharing, and deletion of articles" where you would explain how to create, share, and delete articles". That way they're all grouped up together ideologically, the creation section isn't a one-liner, and the "share" and "access rights" concepts are introduced before the "structure" section.

More general comments: lists take a semi-colon after each line ";", and the final line takes a full stop ".". You can find UTF-8 character set shapes (such as the star) pretty quickly on Google, for future docs (and shapes!)

@LoredanaLrpz LoredanaLrpz force-pushed the 16.0-management-knowledge-lrpz branch 2 times, most recently from a4b2306 to cf0d33e Compare May 17, 2023 10:29
@LoredanaLrpz
Copy link
Contributor Author

Hey @toaa-odoo , thanks for the previous review --> I'm ready for you to review this again. You'll notice I haven't changed the punctuation in the bulleted list, as it's not grammatically mandatory to do at all (not for complete sentences starting with a capital letter).
Wish you a great one!

@LoredanaLrpz LoredanaLrpz requested a review from toaa-odoo May 17, 2023 10:35
Copy link
Contributor

@toaa-odoo toaa-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, just added a suggestion for the tip

@toaa-odoo toaa-odoo requested a review from a team May 23, 2023 11:46
Copy link
Contributor

@xpl-odoo xpl-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 😃
@robodoo delegate+

@LoredanaLrpz LoredanaLrpz force-pushed the 16.0-management-knowledge-lrpz branch from cf0d33e to 7b3744a Compare May 26, 2023 07:12
@LoredanaLrpz
Copy link
Contributor Author

@robodoo r+

@fw-bot
Copy link
Collaborator

fw-bot commented May 30, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants