Skip to content

Conversation

@ralo-odoo
Copy link

Adding Philippines localization documentation to the fiscal localisations folder as it did not exist before. This was to provide instructions for the new Philippine localization module l10n_ph

Adding Philippines localisation documentation to the fiscal localisations folder as it did not exist before. This was to provide instructions for the new Philippine loclisation module l10n_ph
@robodoo
Copy link
Collaborator

robodoo commented Jul 24, 2023

@C3POdoo C3POdoo requested a review from a team July 24, 2023 03:51
Removed trailing white spaces and other formatting issues after PR documentation_guidelines auto check
dade-odoo pushed a commit that referenced this pull request Jul 25, 2023
Fix indent errors & trailing white spaces for auto check
dade-odoo pushed a commit that referenced this pull request Jul 25, 2023
@dade-odoo
Copy link
Contributor

dade-odoo commented Jul 25, 2023

Hi @ralo-odoo , thanks for adding this localization! I'm sure lots of users will find it very helpful.

I noticed that you already fixed a lot of the issues with the guidelines (trailing whitespaces, blank lines after headings and at the end of the document, etc). I fixed the one whitespace that you missed and made a few other edits in another PR: #5187

To clean up the other formatting issues, it was easier for me to create a new PR than to edit yours. For Odoo employees you don't need to create a fork and can instead create a branch on the origin.

One of the other formatting guidelines we follow is to keep lines to 100 characters max to make everything easier to view. Most of the edits I made were minor formatting issues like that plus a few edits for clarity. Please review them and feel free to start a review on that PR if there's anything you would like to discuss further :)

@dade-odoo dade-odoo closed this Jul 25, 2023
@ralo-odoo
Copy link
Author

Hi @dade-odoo , Thank you so much for your feedback and help! It is my first time doing this documentation so I tried to follow the guidelines as much as I could but missed out on the 100 char limit. I have now enabled a 100char ruler in vscodium to assist with this! The other PR looks good so I will delete this branch if its not needed!

@ralo-odoo ralo-odoo deleted the philippines-localisation-ralo branch July 26, 2023 01:40
@dade-odoo
Copy link
Contributor

Hi @ralo-odoo , you're welcome! Thanks for reading our guidelines :) This PR is already closed, so no need to delete anything here and we'll move the other PR forward.

dade-odoo pushed a commit that referenced this pull request Aug 2, 2023
dade-odoo pushed a commit that referenced this pull request Aug 7, 2023
Adding Philippines localization documentation from PR #5179
robodoo pushed a commit that referenced this pull request Aug 7, 2023
Adding Philippines localization documentation from PR #5179

closes #5187

Signed-off-by: Dallas Dean (dade) <dade@odoo.com>
fw-bot pushed a commit that referenced this pull request Aug 7, 2023
Adding Philippines localization documentation from PR #5179

X-original-commit: 465e7e7
fw-bot pushed a commit that referenced this pull request Aug 7, 2023
Adding Philippines localization documentation from PR #5179

X-original-commit: 465e7e7
fw-bot pushed a commit that referenced this pull request Aug 7, 2023
Adding Philippines localization documentation from PR #5179

X-original-commit: 465e7e7
fw-bot pushed a commit that referenced this pull request Aug 7, 2023
Adding Philippines localization documentation from PR #5179

X-original-commit: 465e7e7
fw-bot pushed a commit that referenced this pull request Aug 7, 2023
Adding Philippines localization documentation from PR #5179

X-original-commit: 465e7e7
robodoo pushed a commit that referenced this pull request Aug 7, 2023
Adding Philippines localization documentation from PR #5179

closes #5329

X-original-commit: 465e7e7
Signed-off-by: Dallas Dean (dade) <dade@odoo.com>
robodoo pushed a commit that referenced this pull request Aug 7, 2023
Adding Philippines localization documentation from PR #5179

closes #5328

X-original-commit: 465e7e7
Signed-off-by: Dallas Dean (dade) <dade@odoo.com>
robodoo pushed a commit that referenced this pull request Aug 7, 2023
Adding Philippines localization documentation from PR #5179

closes #5330

X-original-commit: 465e7e7
Signed-off-by: Dallas Dean (dade) <dade@odoo.com>
robodoo pushed a commit that referenced this pull request Aug 7, 2023
Adding Philippines localization documentation from PR #5179

closes #5331

X-original-commit: 465e7e7
Signed-off-by: Dallas Dean (dade) <dade@odoo.com>
robodoo pushed a commit that referenced this pull request Aug 7, 2023
Adding Philippines localization documentation from PR #5179

closes #5332

X-original-commit: 465e7e7
Signed-off-by: Dallas Dean (dade) <dade@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants