-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[ADD] Documentation: add Philippines Localisation #5179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding Philippines localisation documentation to the fiscal localisations folder as it did not exist before. This was to provide instructions for the new Philippine loclisation module l10n_ph
Removed trailing white spaces and other formatting issues after PR documentation_guidelines auto check
Fix indent errors & trailing white spaces for auto check
|
Hi @ralo-odoo , thanks for adding this localization! I'm sure lots of users will find it very helpful. I noticed that you already fixed a lot of the issues with the guidelines (trailing whitespaces, blank lines after headings and at the end of the document, etc). I fixed the one whitespace that you missed and made a few other edits in another PR: #5187 To clean up the other formatting issues, it was easier for me to create a new PR than to edit yours. For Odoo employees you don't need to create a fork and can instead create a branch on the origin. One of the other formatting guidelines we follow is to keep lines to 100 characters max to make everything easier to view. Most of the edits I made were minor formatting issues like that plus a few edits for clarity. Please review them and feel free to start a review on that PR if there's anything you would like to discuss further :) |
|
Hi @dade-odoo , Thank you so much for your feedback and help! It is my first time doing this documentation so I tried to follow the guidelines as much as I could but missed out on the 100 char limit. I have now enabled a 100char ruler in vscodium to assist with this! The other PR looks good so I will delete this branch if its not needed! |
|
Hi @ralo-odoo , you're welcome! Thanks for reading our guidelines :) This PR is already closed, so no need to delete anything here and we'll move the other PR forward. |
Adding Philippines localization documentation from PR #5179
Adding Philippines localization documentation to the fiscal localisations folder as it did not exist before. This was to provide instructions for the new Philippine localization module l10n_ph