[IMP] Productivity: Outlook Plugin edits #6456
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Contributor
Author
|
UPDATE: FIXED @LNAodoo When you have a moment can you take a look at this error that I'm receiving when testing: |
tiku-odoo
force-pushed
the
15.0-Productivity-Outlook-Plugin-Update-Process-tiku
branch
from
2b50d01 to
33ea337
Compare
tiku-odoo
requested review from
StraubCreative
and removed request for
LNAodoo
Contributor
Author
|
This PR is ready for your review. This is a quick change of the URL step to a file upload for the XML upload. I've also reworded and got rid of the lists. This is labeled priority from LNA Thanks |
StraubCreative
approved these changes
Nov 15, 2023
Contributor
StraubCreative
left a comment
StraubCreative
left a comment
There was a problem hiding this comment.
Hi @tiku-odoo
Approving with comments
- line 89 is too long
- line 118 was broken too early.
- general comment: missing written specificity in a number of sentences and relying too much on screenshots
- grammar: we're missing some conjunctions in some spots so sentences that seem complete are actually fragments.
@robodoo delegate=tiku-odoo
tiku-odoo
force-pushed
the
15.0-Productivity-Outlook-Plugin-Update-Process-tiku
branch
from
33ea337 to
e37da5d
Compare
Contributor
Author
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Nov 15, 2023
closes #6456 Signed-off-by: Timothy Kukulka (tiku) <tiku@odoo.com>
This was referenced Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks:
https://www.odoo.com/web#id=3594588&cids=3&model=project.task&view_type=form
https://www.odoo.com/web#id=3574085&cids=3&menu_id=4720&action=333&active_id=3835&model=project.task&view_type=form