Skip to content

Conversation

@fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Nov 15, 2023

Revision of Average inventory valuation cost method.
Task ID: #3255051

Summary

Hi! I'm newly assigned to the inventory scope and wanted to update this inventory valuation doc for Odoo 14 and elaborate the accounting concepts in layman's terms. If you are able to fact-check and expand on the accounting concepts, I would greatly appreciate it!

Other changes

  • Add math formulas to elaborate the journal entry calculations about inventory valuation
  • Add more headings for organization (because the document got LONG very quickly)
  • Renamed headings to be action-oriented and sentence case
  • Add external links to related docs
  • Remove instances of "I", "our", "we" and other pronouns
  • Rewritten for clarity (not brevity)

Things to look out for in the review

(in order of importance)

  1. What do you think about the Anglo-Saxon section (lines 186-266)
  2. Does the definition of AVCO make sense?
  3. Are the accounting concepts clear & accurate?
  4. Do math explanations make sense?
  5. Can they be shortened a little?
  6. How is the organization of examples?
  7. Do intros of sections seem redundant?

This PR is intended to be FW ported

Forward-Port-Of: #6424
Forward-Port-Of: #4005

@robodoo
Copy link
Collaborator

robodoo commented Nov 15, 2023

@fw-bot
Copy link
Collaborator Author

fw-bot commented Nov 15, 2023

@Felicious @StraubCreative cherrypicking of pull request #4005 failed.

stdout:

Auto-merging content/applications/inventory_and_mrp/inventory/management/reporting/inventory_valuation_config.rst
Auto-merging content/applications/inventory_and_mrp/inventory/management/reporting/using_inventory_valuation.rst
CONFLICT (content): Merge conflict in content/applications/inventory_and_mrp/inventory/management/reporting/using_inventory_valuation.rst

stderr:

07:39:21.187278 git.c:463               trace: built-in: git cherry-pick 20bd9582b5753d2d9150703d6a8aaad14538c509
error: could not apply 20bd9582b... [IMP] inventory: expand on accounting and math
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@Felicious Felicious force-pushed the 16.0-14.0-inventory-avg-price-val-on-returned-goods-feku-sDHH-fw branch from 6cca7d4 to 99dcc80 Compare November 15, 2023 16:14
@C3POdoo C3POdoo requested review from a team November 15, 2023 16:16
X-original-commit: 058515e
Co-authored-by: toaa <104567387+toaa-odoo@users.noreply.github.com>
Co-authored-by: meng-odoo <101904966+meng-odoo@users.noreply.github.com>
@Felicious Felicious force-pushed the 16.0-14.0-inventory-avg-price-val-on-returned-goods-feku-sDHH-fw branch from 99dcc80 to 7c57e97 Compare November 15, 2023 16:20
@Felicious
Copy link
Contributor

Hi @StraubCreative :D cherry-picked and resolved the merge conflict. all checks pass, we can try merging again

@StraubCreative
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Nov 15, 2023
closes #6458

X-original-commit: 058515e
Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
Co-authored-by: toaa <104567387+toaa-odoo@users.noreply.github.com>
Co-authored-by: meng-odoo <101904966+meng-odoo@users.noreply.github.com>
@robodoo robodoo closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants