Skip to content

[ADD] crm: quality leads report doc #7966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jero-odoo wants to merge 1 commit into from
Closed

[ADD] crm: quality leads report doc #7966

jero-odoo wants to merge 1 commit into from

Conversation

@jero-odoo
Copy link
Contributor

@jero-odoo jero-odoo commented Mar 1, 2024

Adding new doc for CRM quality leads report

@jero-odoo jero-odoo requested a review from StraubCreative March 1, 2024 13:52
@jero-odoo jero-odoo self-assigned this Mar 1, 2024
@robodoo
Copy link
Collaborator

robodoo commented Mar 1, 2024

Pull request status dashboard.

@C3POdoo C3POdoo requested a review from a team March 1, 2024 14:05
ksc-odoo
ksc-odoo approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jero-odoo -- just finished my peer review on this. nice job! Only a handful of things that require your attention. but, once you make the necessary adjustments, you should feel free to move this to the next stage. Thanks!

@jero-odoo jero-odoo force-pushed the 17.0-crm-quality-leads-jero branch from 0c7f6d1 to 41bd245 Compare March 9, 2024 00:06
@jero-odoo jero-odoo requested a review from a team March 9, 2024 00:07
@jero-odoo
Copy link
Contributor Author

jero-odoo commented Mar 9, 2024

@samueljlieber This is ready for technical review. Thanks!

@ksc-odoo
Copy link
Contributor

ksc-odoo commented Mar 9, 2024

@jero-odoo -- that was actual my Peer Review (not Final) -- please make the suggested adjustments and tag me again for Final before moving this to Tech. Thanks

@ksc-odoo
Copy link
Contributor

ksc-odoo commented Mar 9, 2024

@jero-odoo I believe more work and more detailed steps will be needed before this one is ready for Tech

@ksc-odoo
Copy link
Contributor

ksc-odoo commented Mar 9, 2024

@samueljlieber This is ready for technical review. Thanks!

@samueljlieber please hold off on Tech Review until this passes my Final Review. Thank you

@jero-odoo jero-odoo removed the request for review from a team March 9, 2024 01:08
StraubCreative
StraubCreative requested changes Mar 9, 2024
View reviewed changes
Copy link
Contributor

@StraubCreative StraubCreative left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jero-odoo
Similar markup and presentation issues here compared to #7965
Can you take another look and validate:

  • RST markup
  • specificity of language
  • depth of content: UI and form coverage
  • transitional language
  • grammar/wording
  • etc

Thank you and please let me know if you have any questions!

@jero-odoo jero-odoo force-pushed the 17.0-crm-quality-leads-jero branch from 1f0d4a2 to 1a97047 Compare March 13, 2024 14:41
@jero-odoo
Copy link
Contributor Author

jero-odoo commented Mar 13, 2024

Thanks @StraubCreative , this is ready for another review. A couple of things I would appreciate input on
-The order, specifically about the "defining a quality leads" section. It is currently at the end, since it is optional to add those additional fields, but I debated having it after the intro.
-The defining quality leads section as a whole, and whether it needs to be more detailed. I wasn't sure if I needed to go more in depth about selecting other filters beyond showing some examples, since there is so much gray area there.

Let me know if you want to discuss this. Thanks!

StraubCreative
StraubCreative requested changes Mar 16, 2024
View reviewed changes
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jero-odoo
Good changes last round, this is really starting to come together 💪
I have some more feedback to further contextualize the information, be more specific with certain instructions, and answer your prior questions about the last section.
Almost there, let's keep going!

content/applications/sales/crm/track_leads/quality_leads_report.rst Outdated
graph, where the leads are grouped by *stage*.

To group the results by salesperson, click the :guilabel:`🔻(triangle pointed down)` icon to the
right of the :guilabel:`Search...` bar to open the drop-down menu. Under the :guilabel:`Group By`
Copy link
Contributor

@StraubCreative StraubCreative Mar 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in web design, we call this kind of drop-down a mega menu.

Suggested change
right of the :guilabel:`Search...` bar to open the drop-down menu. Under the :guilabel:`Group By`
right of the :guilabel:`Search...` bar to open the drop-down mega menu. Under the :guilabel:`Group By`

Copy link
Contributor Author

@jero-odoo jero-odoo Mar 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, but "drop-down mega menu" always seems excessively long and repetitive to me. Do we need to have both?

Copy link
Contributor

@StraubCreative StraubCreative Mar 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I see your point...it's a bit much 😄
Would just say mega menu then, i.e. "bar to open the mega menu"
Can implement on future PRs too, doesn't need to be this one actually.

@jero-odoo jero-odoo force-pushed the 17.0-crm-quality-leads-jero branch from ea7662f to 6560b6f Compare March 18, 2024 14:11
@jero-odoo
Copy link
Contributor Author

jero-odoo commented Mar 18, 2024

@StraubCreative Changes made, can you take another look? Thanks!

@C3POdoo C3POdoo requested a review from a team March 18, 2024 14:13
AntoineVDV
AntoineVDV reviewed Mar 18, 2024
View reviewed changes
@jero-odoo @AntoineVDV
[ADD] crm: quality leads report doc
bb81a32 
Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com>

Co-authored-by: Zachary Straub <zst@odoo.com>

Co-authored-by: Zachary Straub <zst@odoo.com>

Co-authored-by: Antoine Vandevenne (anv) <anv@odoo.com>
@jero-odoo jero-odoo force-pushed the 17.0-crm-quality-leads-jero branch from 5b314fe to bb81a32 Compare March 18, 2024 14:23
StraubCreative
StraubCreative approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice job @jero-odoo !
.....
@robodoo r+

@robodoo robodoo closed this in c63dda1 Mar 22, 2024
@fw-bot fw-bot mentioned this pull request Mar 22, 2024
Closed
@fw-bot fw-bot mentioned this pull request Mar 22, 2024
Closed
@fw-bot fw-bot mentioned this pull request Mar 22, 2024
Closed
@fw-bot
Copy link
Collaborator

fw-bot commented Mar 26, 2024

@jero-odoo @StraubCreative this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Collaborator

fw-bot commented Mar 27, 2024

@jero-odoo @StraubCreative this pull request has forward-port PRs awaiting action (not merged or closed):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AntoineVDV AntoineVDV AntoineVDV left review comments

@StraubCreative StraubCreative StraubCreative approved these changes

+1 more reviewer

@ksc-odoo ksc-odoo ksc-odoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jero-odoo jero-odoo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jero-odoo @robodoo @ksc-odoo @fw-bot @StraubCreative @AntoineVDV