-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[IMP] essentials: iap graphics update and rewrite #8812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
589ec2d to
3ba6f8b
Compare
3ba6f8b to
fd55eaa
Compare
|
Here is a review for you, if you have some time. This was recently re-written by Max and reviewed by you. I've updated the graphics and made a couple of changes to the formatting. Additionally, I've edited lines 24-26. Originally this was only pushed to Odoo 17 for some very minor changes. I've adapted this document so that we can push to the outdated versions of Odoo 15/16 documentation. Thanks, |
fd55eaa to
676ea7e
Compare
larm-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tiku-odoo - not a lot of changes, mostly things to double check against the runbot examples I saw. Approving now, but LMK if you need any explanations for my comments!
676ea7e to
cd94164
Compare
|
@larm-odoo Thanks for your review 👍 @ksc-odoo Thanks, |
ksc-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this @tiku-odoo -- just finished my Final Review, and there is only a handful of minor suggestions that require your attention. Once you've implemented the necessary changes, please feel free to tag this for Tech Review. Thanks! 👍
cd94164 to
d9fc189
Compare
|
This doc is ready for your review when you have a moment. Thanks, |
samueljlieber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tiku-odoo, nice job on this PR! These changes look good to me. I am approving now and delegating merge to you, with just a couple of quick fixes for you below.
...
@robodoo delegate=tiku-odoo
d9fc189 to
bcb1c6f
Compare
|
@robodoo r+ |
closes #8812 Signed-off-by: Timothy Kukulka (tiku) <tiku@odoo.com>
|
@tiku-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
Take the rewrite that was pushed in #7427 and cherry-picking to Odoo 15/16 documentation.
Task:
https://www.odoo.com/web?debug=1#id=2753507&cids=3&menu_id=4720&action=333&active_id=3835&model=project.task&view_type=form