Skip to content

Conversation

@tiku-odoo
Copy link
Contributor

@tiku-odoo tiku-odoo commented Apr 17, 2024

Take the rewrite that was pushed in #7427 and cherry-picking to Odoo 15/16 documentation.

Task:
https://www.odoo.com/web?debug=1#id=2753507&cids=3&menu_id=4720&action=333&active_id=3835&model=project.task&view_type=form

@robodoo
Copy link
Collaborator

robodoo commented Apr 17, 2024

@C3POdoo C3POdoo requested review from a team April 17, 2024 17:51
@tiku-odoo tiku-odoo changed the title [IMP] essentials: iap rewrite and graphics update [IMP] essentials: iap graphics update and scope specific use Apr 17, 2024
@tiku-odoo tiku-odoo changed the title [IMP] essentials: iap graphics update and scope specific use [IMP] essentials: iap graphics update and rewrite Apr 17, 2024
@tiku-odoo tiku-odoo force-pushed the 15.0-essentials-iap-rewrite-tiku branch from 589ec2d to 3ba6f8b Compare April 17, 2024 18:32
@tiku-odoo tiku-odoo requested review from jero-odoo and removed request for jero-odoo April 17, 2024 18:32
@tiku-odoo tiku-odoo force-pushed the 15.0-essentials-iap-rewrite-tiku branch from 3ba6f8b to fd55eaa Compare April 17, 2024 19:04
@tiku-odoo
Copy link
Contributor Author

@larm-odoo

Here is a review for you, if you have some time. This was recently re-written by Max and reviewed by you. I've updated the graphics and made a couple of changes to the formatting. Additionally, I've edited lines 24-26.

Originally this was only pushed to Odoo 17 for some very minor changes. I've adapted this document so that we can push to the outdated versions of Odoo 15/16 documentation.

Thanks,
Tim 👍

@tiku-odoo tiku-odoo requested a review from larm-odoo April 18, 2024 12:51
@tiku-odoo tiku-odoo force-pushed the 15.0-essentials-iap-rewrite-tiku branch from fd55eaa to 676ea7e Compare April 18, 2024 13:09
Copy link
Contributor

@larm-odoo larm-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tiku-odoo - not a lot of changes, mostly things to double check against the runbot examples I saw. Approving now, but LMK if you need any explanations for my comments!

@tiku-odoo tiku-odoo force-pushed the 15.0-essentials-iap-rewrite-tiku branch from 676ea7e to cd94164 Compare April 18, 2024 19:25
@tiku-odoo tiku-odoo requested a review from a team April 18, 2024 19:30
@tiku-odoo
Copy link
Contributor Author

@larm-odoo Thanks for your review 👍

@ksc-odoo
This doc is ready for your review when you have a moment.

Thanks,
Tim

Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this @tiku-odoo -- just finished my Final Review, and there is only a handful of minor suggestions that require your attention. Once you've implemented the necessary changes, please feel free to tag this for Tech Review. Thanks! 👍

@tiku-odoo tiku-odoo force-pushed the 15.0-essentials-iap-rewrite-tiku branch from cd94164 to d9fc189 Compare April 22, 2024 15:41
@tiku-odoo tiku-odoo requested a review from a team April 22, 2024 15:41
@tiku-odoo
Copy link
Contributor Author

@samueljlieber

This doc is ready for your review when you have a moment.

Thanks,
Tim 👍

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tiku-odoo, nice job on this PR! These changes look good to me. I am approving now and delegating merge to you, with just a couple of quick fixes for you below.
...
@robodoo delegate=tiku-odoo

@tiku-odoo tiku-odoo force-pushed the 15.0-essentials-iap-rewrite-tiku branch from d9fc189 to bcb1c6f Compare April 22, 2024 18:32
@tiku-odoo
Copy link
Contributor Author

@robodoo r+

robodoo pushed a commit that referenced this pull request Apr 22, 2024
closes #8812

Signed-off-by: Timothy Kukulka (tiku) <tiku@odoo.com>
@fw-bot
Copy link
Collaborator

fw-bot commented Apr 26, 2024

@tiku-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants