-
Notifications
You must be signed in to change notification settings - Fork 10.9k
[ADD] crm: new lead distribution report #9915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @pabr-odoo -- just finished my Review on this PR. Really great job. Awesome attention to detail here. That said, I do have a fairly decent amount of comments/feedback/suggestions, etc. that require your attention. So, if you could give those a look, and implement the necessary adjustments, then you can tag me again for another quick look. Once we iron out those details, I'll give ya the go ahead for the next stage. Thanks! 👍
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
1ab4bed to
c021c0e
Compare
|
Hey @ksc-odoo I implemented your suggestions. Please give it a look over when you get the chance and let me know if there's any changes that still need to be made. Thanks! |
ksc-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @pabr-odoo -- just gave this one another look. great job on the revisions so far. Just a handful of other suggestions/comments that require your attention. Once you implement those, feel free to tag this for Tech Review. Thanks! 👍
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
be678b0 to
50e6f03
Compare
|
Hey @samueljlieber tagging this new doc for tech review when you get the chance. Thanks! |
StraubCreative
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pabr-odoo
A few outstanding items before we can continue the tech review.
- too many screenshots, try to include only what's necessary or completely filled out forms (instead of multiple micro shots)
- we cannot use screenshots of the internal odoo database so like
filters-dropdown.pngfor examples is a no go. - there are some screenshots (and maybe instructions) that are not necessary for this report, they are supplemental to further filter for quality leads. All of the stuff around lead sourcing (does not contain personal email addresses, Source is livechat) is extra.
- I'm mentioning it bc I don't want readers to misunderstand what is necessary vs. what is helpful/extra (does that make sense?)
- merge conflict that has to be solved on
crm.rst
945959c to
901c0e2
Compare
36b7695 to
5ddb82f
Compare
|
Hey @StraubCreative thanks again for your feedback! This should hopefully be good to go for tech review now when you get the chance. |
5ddb82f to
8d8cdf2
Compare
|
8d8cdf2: fixes all line-break issues (about 9 or so in total). @pabr-odoo let's take a look at your linter and VSCode setup to make sure those are all set up correctly bc they will help with a lot of things such as early/late line breaks 👍 |
StraubCreative
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pabr-odoo
Good push last round!
To continue dialing this in for accuracy, formatting, and being concise, I have some more feedback for you below. You should be able to batch commit a lot of it and then for the latter material we can discuss if you like.
Thank you for your continued effort on this, and please tag me again when it's ready for another review 🤙
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
8d8cdf2 to
9350145
Compare
|
Thanks again @StraubCreative for all your effort in helping with this doc. I implemented the changes you suggested before and think it's looking great with this round of suggestions. Please take another look whenever you get the chance. |
StraubCreative
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pabr-odoo
Great effort, I think this came out nicely! 👍
Approving with some optional comments for you to consider.
When you're ready to move forward, please tag @samueljlieber for tech review/merge, thanks!
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
9350145 to
c93df3d
Compare
|
Hey @samueljlieber this is ready for tech review whenever you're free. Thanks so much! |
samueljlieber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pabr-odoo! Fantastic job on this new CRM doc on creating a lead distribution report 👏 This is a really great reference and I like how you covered custom filters in a way that readers should feel empowered to create their own personalized reports.
I know I have a number of fixes, but don't be discouraged! These are all minor changes for RST syntax and our doc guidelines, and some suggestions, overall this PR is looking great!
Please tag me for one more quick look once each of my suggestions are addressed, thank you!
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report/add-email.png
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report/add-notes.png
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report/add-salesperson.png
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report/any-to-all.png
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report/referred-by.png
Outdated
Show resolved
Hide resolved
823fdc5 to
a78de48
Compare
|
Hey @samueljlieber thanks so much for the encouragement and thorough review! I addressed all your changes, but added back the seealso admonition at the very end of the doc and kept "active-set.png" as it was used in the doc. Please let me know if I'm mistaken, or if anything else needs to be addressed. Thanks again for all your hard work! |
samueljlieber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pabr-odoo! Nice work, your PR is looking great! Approving with two more quick fixes, thank you for your work! Please merge after addressing these two :)
.....
@robodoo delegate=pabr-odoo
content/applications/sales/crm/track_leads/lead_distribution_report/add-custom-filters.png
Outdated
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/lead_distribution_report.rst
Outdated
Show resolved
Hide resolved
a78de48 to
fc12622
Compare
|
@robodoo r+ |

Task card: https://www.odoo.com/odoo/project/3835/tasks/3985571
Adding a new doc to CRM on generating a lead distribution report from the CRM pipeline.