Skip to content

[IMP] update developer training docs for v15 + extra tweaks #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[IMP] update developer training docs for v15 + extra tweaks #1146

wants to merge 3 commits into from

Conversation

@ticodoo
Copy link
Contributor

@ticodoo ticodoo commented Sep 16, 2021

Update dev training docs to match v15 changes/standards:

  • Reference v15 training solutions
  • Refer to Command namespace instead of triplets (e.g.
    Command.create(values) instead of (0, 0, values)
  • Add notice about OWL transition
  • Add reference to @api.ondelete (instead of override unlink())

Also:

  • Also add missing reference documentation for ondelete
  • proofread adv topics (fixed small grammar mistakes/ cleaned up language flow) + add missing info for dashboard topic
  • Push linters more on newbies due to complaints of them not setting up their linters

@robodoo
Copy link
Collaborator

robodoo commented Sep 16, 2021

Pull request status dashboard.

@ticodoo ticodoo requested a review from a team September 16, 2021 07:33
Feyensv
Feyensv reviewed Sep 16, 2021
View reviewed changes
Copy link
Collaborator

@Feyensv Feyensv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't notice there were that much typos in those trainings, I should have made a pass of codespell before the merge 👍

Not much to say, one or two true remarks, majority of the changes LGTM.
Thanks for taking the time to update the training 💙

@ticodoo ticodoo force-pushed the saas-14.5-developer-tutorials-update-tic branch from 6835e7f to 049021c Compare September 16, 2021 13:04
ticodoo
ticodoo commented Sep 16, 2021
View reviewed changes
Copy link
Contributor Author

@ticodoo ticodoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review @Feyensv ! Hopefully we will have better trained devs now 😆

AntoineVDV
AntoineVDV reviewed Sep 17, 2021
View reviewed changes
@ticodoo ticodoo force-pushed the saas-14.5-developer-tutorials-update-tic branch from 049021c to 915459b Compare September 17, 2021 10:04
@AntoineVDV
Copy link
Collaborator

@ticodoo When you're done with the changes don't forget to re-request our review so that we can r+ ;)

NB: The runbot seems to be broken atm, we're working on it.

@ticodoo ticodoo requested a review from a team September 20, 2021 09:38
@ticodoo
Copy link
Contributor Author

ticodoo commented Sep 20, 2021

@AntoineVDV Oops sorry. It's already ready for another review 😅

@ticodoo @AntoineVDV
[IMP] developer/howtos: encourage linters more
414dfde 
There have been complaints of newbies not setting up their linters
therefore let's emphasize their use/setup more in the tutorial and hope
for the best.
@ticodoo @AntoineVDV
[IMP] developer/howtos: proofread adv topics
893b43d 
- Cleaned up the language a tiny bit
- Fixed small errors/typos
- Add some missing info for dashboard topic
- Updated unit test exercise to match what's in the solutions repo
@AntoineVDV AntoineVDV force-pushed the saas-14.5-developer-tutorials-update-tic branch from 915459b to 11d5edd Compare September 20, 2021 09:56
@AntoineVDV
Copy link
Collaborator

@robodoo rebase-ff

@robodoo
Copy link
Collaborator

robodoo commented Sep 20, 2021

Merge method set to rebase and fast-forward

AntoineVDV
AntoineVDV reviewed Sep 20, 2021
View reviewed changes
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out the branch simply needed to be rebased onto saas-14.5.

@ticodoo
[IMP] developer/{howtos,reference}: update training to match v15 changes
a231914 
- Reference v15 training solutions
- Refer to Command namespace instead of triplets (e.g.
  Command.create(values) instead of (0, 0, values)
- Add notice about OWL transition
- Add reference to @api.ondelete (instead of override unlink())
- Remove references to SavepointCase (now only TransactionCase) from
  unit test topic

- Also add missing reference documentation for ondelete
ticodoo
ticodoo commented Sep 20, 2021
View reviewed changes
Copy link
Contributor Author

@ticodoo ticodoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the rebase. I thought I already rebased it but obviously I didn't, so I'll just hang my head in shame now.

@ticodoo ticodoo force-pushed the saas-14.5-developer-tutorials-update-tic branch from 11d5edd to a231914 Compare September 20, 2021 11:31
@AntoineVDV
Copy link
Collaborator

Thanks for your contribution :)

@robodoo r+

robodoo pushed a commit that referenced this pull request Sep 20, 2021
@ticodoo @AntoineVDV
[IMP] developer/howtos: encourage linters more
85410bd 
There have been complaints of newbies not setting up their linters
therefore let's emphasize their use/setup more in the tutorial and hope
for the best.

Part-of: #1146
robodoo pushed a commit that referenced this pull request Sep 20, 2021
@ticodoo @AntoineVDV
[IMP] developer/howtos: proofread adv topics
b3845ae 
- Cleaned up the language a tiny bit
- Fixed small errors/typos
- Add some missing info for dashboard topic
- Updated unit test exercise to match what's in the solutions repo

Part-of: #1146
robodoo pushed a commit that referenced this pull request Sep 20, 2021
@ticodoo
[IMP] developer/{howtos,reference}: update training to match v15 changes
bb3996b 
- Reference v15 training solutions
- Refer to Command namespace instead of triplets (e.g.
  Command.create(values) instead of (0, 0, values)
- Add notice about OWL transition
- Add reference to @api.ondelete (instead of override unlink())
- Remove references to SavepointCase (now only TransactionCase) from
  unit test topic

- Also add missing reference documentation for ondelete

closes #1146

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
@fw-bot fw-bot mentioned this pull request Sep 20, 2021
Closed
@robodoo robodoo closed this Sep 20, 2021
@robodoo robodoo temporarily deployed to merge September 20, 2021 11:54 Inactive
@fw-bot fw-bot deleted the saas-14.5-developer-tutorials-update-tic branch October 4, 2021 12:47
AntoineVDV pushed a commit that referenced this pull request Oct 5, 2021
@ticodoo @AntoineVDV
[IMP] developer/howtos: encourage linters more
c1b8e7f 
There have been complaints of newbies not setting up their linters
therefore let's emphasize their use/setup more in the tutorial and hope
for the best.

Part-of: #1146
AntoineVDV pushed a commit that referenced this pull request Oct 5, 2021
@ticodoo @AntoineVDV
[IMP] developer/howtos: proofread adv topics
c0aba50 
- Cleaned up the language a tiny bit
- Fixed small errors/typos
- Add some missing info for dashboard topic
- Updated unit test exercise to match what's in the solutions repo

Part-of: #1146
AntoineVDV pushed a commit that referenced this pull request Oct 5, 2021
@ticodoo @AntoineVDV
[IMP] developer/{howtos,reference}: update training to match v15 changes
9195e02 
- Reference v15 training solutions
- Refer to Command namespace instead of triplets (e.g.
  Command.create(values) instead of (0, 0, values)
- Add notice about OWL transition
- Add reference to @api.ondelete (instead of override unlink())
- Remove references to SavepointCase (now only TransactionCase) from
  unit test topic

- Also add missing reference documentation for ondelete

closes #1146

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AntoineVDV AntoineVDV AntoineVDV approved these changes

@Feyensv Feyensv Feyensv left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ticodoo @robodoo @AntoineVDV @Feyensv