[IMP] Inventory: add delivery slip setting to serial numbers #11697
Conversation
|
|
hojo-odoo
force-pushed
the
18.0-inventory-update-serial-numbers-delivery-slip-hojo
branch
from
ecb7132 to
c3251da
Compare
|
Hey @benderliz, This PR is ready for the first round of review. Thanks, |
There was a problem hiding this comment.
Hi @hojo-odoo! GREAT work on this section! Your writing is so clear, specific, and worked seamlessly in runbot. I re-wrote this doc a few months ago, and now having more experience, I see what a great addition this is :) Thank you for making it much better!
I had a couple stylistic suggestions (mostly minor, but the one I'm most curious for your thoughts on is about where to include this section within the doc). Feel free to DM with any questions / to discuss! Ready for final review after checking these.
...lications/inventory_and_mrp/inventory/product_management/product_tracking/serial_numbers.rst
Outdated
Show resolved
Hide resolved
...lications/inventory_and_mrp/inventory/product_management/product_tracking/serial_numbers.rst
Outdated
Show resolved
Hide resolved
...lications/inventory_and_mrp/inventory/product_management/product_tracking/serial_numbers.rst
Outdated
Show resolved
Hide resolved
...lications/inventory_and_mrp/inventory/product_management/product_tracking/serial_numbers.rst
Outdated
Show resolved
Hide resolved
...lications/inventory_and_mrp/inventory/product_management/product_tracking/serial_numbers.rst
Outdated
Show resolved
Hide resolved
...lications/inventory_and_mrp/inventory/product_management/product_tracking/serial_numbers.rst
Outdated
Show resolved
Hide resolved
hojo-odoo
force-pushed
the
18.0-inventory-update-serial-numbers-delivery-slip-hojo
branch
from
c3251da to
467391c
Compare
|
Hey @Felicious, This PR is ready for final review. Thanks, |
|
Hi @hojo-odoo! I left comments on the lot number PR, which are relevant here too. Once you’ve addressed those, please update this PR accordingly and tag me. I’ll review it quickly after that—thanks! 😊 |
hojo-odoo
force-pushed
the
18.0-inventory-update-serial-numbers-delivery-slip-hojo
branch
from
467391c to
0d2a14e
Compare
There was a problem hiding this comment.
Great job, @hojo-odoo ! I just fixed a typo and other than that, this PR is ready to go after you take a look through the other suggestions!
...lications/inventory_and_mrp/inventory/product_management/product_tracking/serial_numbers.rst
Outdated
Show resolved
Hide resolved
...lications/inventory_and_mrp/inventory/product_management/product_tracking/serial_numbers.rst
Outdated
Show resolved
Hide resolved
...lications/inventory_and_mrp/inventory/product_management/product_tracking/serial_numbers.rst
Outdated
Show resolved
Hide resolved
...lications/inventory_and_mrp/inventory/product_management/product_tracking/serial_numbers.rst
Outdated
Show resolved
Hide resolved
hojo-odoo
force-pushed
the
18.0-inventory-update-serial-numbers-delivery-slip-hojo
branch
from
0d2a14e to
9a41e21
Compare
|
Hey @samueljlieber, This PR is ready for technical review. Thanks, |
There was a problem hiding this comment.
Hi @hojo-odoo, nice work! Looks good to me, thank you!
..
@robodoo r+
closes #11697 Signed-off-by: Samuel Lieber (sali) <sali@odoo.com>
closes #11697 Signed-off-by: Samuel Lieber (sali) <sali@odoo.com>
closes #11697 Signed-off-by: Samuel Lieber (sali) <sali@odoo.com>
closes #11697 Signed-off-by: Samuel Lieber (sali) <sali@odoo.com>
5 participants
This PR adds a new section to the serial numbers doc, detailing how to include serial numbers on delivery slips.