Skip to content

[IMP] developer: add page on owl component system #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Parent: Fix a typo: user menu registry example
wants to merge 1 commit into from
Closed

[IMP] developer: add page on owl component system #1178

wants to merge 1 commit into from

Conversation

@ged-odoo
Copy link
Contributor

No description provided.

@robodoo
Copy link
Collaborator

robodoo commented Oct 14, 2021

Pull request status dashboard.

SimonGenin
SimonGenin approved these changes Oct 14, 2021
View reviewed changes
@ged-odoo ged-odoo marked this pull request as ready for review October 14, 2021 10:50
@ged-odoo
Copy link
Contributor Author

@odoo/doc-review this one is ready for a first doc review :)

AntoineVDV
AntoineVDV reviewed Oct 15, 2021
View reviewed changes
@ged-odoo
Copy link
Contributor Author

@odoo/doc-review thanks for the review. I think I applied all your suggested changes

@ged-odoo ged-odoo requested a review from AntoineVDV October 15, 2021 13:09
AntoineVDV
AntoineVDV reviewed Oct 15, 2021
View reviewed changes
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good!

There is an unresolved comment from the previous review too: #1178 (comment)

@ged-odoo ged-odoo force-pushed the 15.0-js-doc-ged branch 2 times, most recently from a1da475 to 775faeb Compare October 15, 2021 14:18
@ged-odoo
Copy link
Contributor Author

pr updated

@ged-odoo ged-odoo requested a review from AntoineVDV October 15, 2021 14:18
@AntoineVDV
Copy link
Collaborator

@robodoo delegate+

@ged-odoo LGTM but the toctree is conflicting because of the other PR that was just merged. Take the chance to update the seealso in both pages ;)

@ged-odoo
Copy link
Contributor Author

robodoo r+

@robodoo robodoo closed this in b4e8e47 Oct 15, 2021
@fw-bot fw-bot mentioned this pull request Oct 15, 2021
Closed
@robodoo robodoo temporarily deployed to merge October 15, 2021 15:05 Inactive
@fw-bot fw-bot deleted the 15.0-js-doc-ged branch October 29, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AntoineVDV AntoineVDV Awaiting requested review from AntoineVDV

1 more reviewer

@SimonGenin SimonGenin SimonGenin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ged-odoo @robodoo @AntoineVDV @SimonGenin