Skip to content

Conversation

@ged-odoo
Copy link
Contributor

This commit moves most of the content out of the javascript reference
and into a more visible page.

@robodoo
Copy link
Collaborator

robodoo commented Oct 17, 2021

@ged-odoo ged-odoo force-pushed the 15.0-js-modules-ged branch from ac6f1cc to cf15833 Compare October 18, 2021 08:25
@ged-odoo
Copy link
Contributor Author

@odoo/doc-review this one is ready I think

@AntoineVDV AntoineVDV self-requested a review October 19, 2021 10:52
Comment on lines 7 to 8
- :ref:`plain javascript files <javascript/plain_javascript>` (no module system),
- :ref:`Odoo modules <javascript/odoo_module>` (using a custom module system),
- :ref:`native javascript module <javascript/native_js_module>`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking: I find it a bit weird to keep the punctuation of a sentence after it has been split into bullet points.

@jcs-odoo what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one of my teacher at university required that all lists were written this way. He was very nitpicky, but at the same time, I learned a lot.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I agree! It can be correct to write this way in English, according to the style guide chosen. (And teachers are right to be nitpicky at times :p )
Universities and colleges all choose their style guide, for capitalization, book reference, punctuation, etc.

For business writing (dev doc included :) ), we tend to avoid using commas and semi-colons in bulleted lists if it is not a sentence. We only use periods (full stops), question and exclamation marks at the end of sentences.

@ged-odoo ged-odoo force-pushed the 15.0-js-modules-ged branch from ecb4296 to 4340b30 Compare October 20, 2021 13:48
@ged-odoo ged-odoo requested a review from AntoineVDV October 20, 2021 13:49
@AntoineVDV
Copy link
Collaborator

@ged-odoo Looks like you forgot to expand the hidden conversations of the review 🤭

@AntoineVDV AntoineVDV removed their request for review October 20, 2021 14:47
@ged-odoo ged-odoo force-pushed the 15.0-js-modules-ged branch 2 times, most recently from 464b6de to 0bd1256 Compare October 20, 2021 18:49
@ged-odoo
Copy link
Contributor Author

omg, github sucks. the hidden parts of the conversation are always hidden, and when you click on load, it only loads the first 20, so you have to click more. And whenever you apply a commit suggestion, it fucking reload the page

@ged-odoo ged-odoo requested a review from AntoineVDV October 20, 2021 18:51
This commit moves most of the content out of the javascript reference
and into a more visible page.
@ged-odoo ged-odoo force-pushed the 15.0-js-modules-ged branch from 7f6c2fd to 41a9db6 Compare October 22, 2021 08:12
@ged-odoo ged-odoo requested a review from AntoineVDV October 22, 2021 08:12
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo
Copy link
Collaborator

robodoo commented Oct 22, 2021

@AntoineVDV, you may want to rebuild or fix this PR as it has failed CI.

@AntoineVDV
Copy link
Collaborator

@robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Oct 22, 2021

I'm sorry, @AntoineVDV. This PR is already reviewed, reviewing it again is useless.

@robodoo robodoo closed this in c6f813f Oct 22, 2021
@robodoo robodoo temporarily deployed to merge October 22, 2021 12:38 Inactive
@fw-bot fw-bot deleted the 15.0-js-modules-ged branch November 5, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants