-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[ADD] developer: add javascript module page #1192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ac6f1cc to
cf15833
Compare
|
@odoo/doc-review this one is ready I think |
| - :ref:`plain javascript files <javascript/plain_javascript>` (no module system), | ||
| - :ref:`Odoo modules <javascript/odoo_module>` (using a custom module system), | ||
| - :ref:`native javascript module <javascript/native_js_module>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicking: I find it a bit weird to keep the punctuation of a sentence after it has been split into bullet points.
@jcs-odoo what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one of my teacher at university required that all lists were written this way. He was very nitpicky, but at the same time, I learned a lot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I agree! It can be correct to write this way in English, according to the style guide chosen. (And teachers are right to be nitpicky at times :p )
Universities and colleges all choose their style guide, for capitalization, book reference, punctuation, etc.
For business writing (dev doc included :) ), we tend to avoid using commas and semi-colons in bulleted lists if it is not a sentence. We only use periods (full stops), question and exclamation marks at the end of sentences.
ecb4296 to
4340b30
Compare
|
@ged-odoo Looks like you forgot to expand the hidden conversations of the review 🤭 |
464b6de to
0bd1256
Compare
|
omg, github sucks. the hidden parts of the conversation are always hidden, and when you click on load, it only loads the first 20, so you have to click more. And whenever you apply a commit suggestion, it fucking reload the page |
This commit moves most of the content out of the javascript reference and into a more visible page.
7f6c2fd to
41a9db6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robodoo r+
|
@AntoineVDV, you may want to rebuild or fix this PR as it has failed CI. |
|
@robodoo r+ |
|
I'm sorry, @AntoineVDV. This PR is already reviewed, reviewing it again is useless. |
This commit moves most of the content out of the javascript reference
and into a more visible page.