Skip to content

[MOV] developer: move assets doc into its own page #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Parent: Fix a typo: user menu registry example
wants to merge 1 commit into from
Closed

[MOV] developer: move assets doc into its own page #1196

wants to merge 1 commit into from

Conversation

@ged-odoo
Copy link
Contributor

No description provided.

@robodoo
Copy link
Collaborator

robodoo commented Oct 18, 2021

Pull request status dashboard.

@ged-odoo ged-odoo requested a review from AntoineVDV October 19, 2021 06:51
AntoineVDV
AntoineVDV requested changes Oct 20, 2021
View reviewed changes
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read this one in diagonal since it's a [MOV]. Still worth cleaning a bit though :)

@ged-odoo ged-odoo requested a review from AntoineVDV October 20, 2021 19:33
AntoineVDV
AntoineVDV requested changes Oct 21, 2021
View reviewed changes
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some lines are now quite long after applying the suggestions from GitHub, you may want to split them.

@ged-odoo ged-odoo requested a review from AntoineVDV October 22, 2021 08:38
AntoineVDV
AntoineVDV approved these changes Oct 22, 2021
View reviewed changes
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo delegate+

(conflict)

@ged-odoo
Copy link
Contributor Author

@robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Oct 22, 2021

@ged-odoo, you may want to rebuild or fix this PR as it has failed CI.

@ged-odoo
Copy link
Contributor Author

@robodoo r+

@ged-odoo
Copy link
Contributor Author

robodoo r+

@robodoo robodoo closed this in e19e136 Oct 22, 2021
@fw-bot fw-bot mentioned this pull request Oct 22, 2021
Closed
@robodoo robodoo temporarily deployed to merge October 22, 2021 13:45 Inactive
@fw-bot fw-bot deleted the 15.0-assets-ged branch November 5, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AntoineVDV AntoineVDV AntoineVDV approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ged-odoo @robodoo @AntoineVDV