-
Couldn't load subscription status.
- Fork 10.4k
[ADD] developer: actionswiper doc added #1315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This doc is related to a component currently available from the master branch of odoo/enterprise. It may not be the right time to add this documentation as it it not available in 15.0. But maybe we can at least start reviewing it @ged-odoo |
aca23be to
503c807
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe use some more realistic function name: doSomething and doSomethingElse instead of Object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i did not know the API for this component. Note that it is not intuitive, in my opinion. It should be something like onLeftSwipe (function), onRightSwipe (function), leftColor, rightColor, ... (with defaults if possible)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I keep the current documentation until the API is changed in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure the screenshot really helps. I would change it to a screenshot of a single action swiper, nothing else, and put it in the description section. Then, remove this and the sentence l283
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I edited the screenshot to only show one simple component. You're right, it's better like that. I like images in documentations, it helps me as a developer to see what it can do (so please keep this image and encourage the practice :) )
503c807 to
73f8bda
Compare
73f8bda to
298179b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robodoo delegate=ged-odoo
This commit adds the developer documentation for a component recently added to the web_enterprise module. It also includes examples and a screenshot used in the documentation.
298179b to
77635aa
Compare
|
robodoo r+ |
This commit adds the developer documentation for a component recently added to the web_enterprise module. It also includes examples and a screenshot used in the documentation. closes #1315 Signed-off-by: Géry Debongnie <ged@odoo.com>
|
This pull request has forward-port PRs awaiting action (not merged or closed): #1432 |
1 similar comment
|
This pull request has forward-port PRs awaiting action (not merged or closed): #1432 |
This commit adds the developer documentation for a
component recently added to the web_enterprise module.
It also includes examples and a screenshot used in the
documentation.