-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[IMP] POS: Update "Payment methods" doc #14783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d391b1e to
049b780
Compare
049b780 to
3db7ff4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this much-needed update @emmi-odoo! 🙏 As usual, please reach out if anything unclear or needs discussing!
| - If the :doc:`Urban Piper </applications/sales/point_of_sale/online_food_delivery>` setting is | ||
| enabled in the :ref:`POS settings <configuration/settings>`, the :guilabel:`Delivery Payment` | ||
| option appears on the :guilabel:`Payment Method` form and is used for online delivery payments. | ||
| Select a :guilabel:`Delivery Provider` to configure the option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not super clear to me the link between UrbanPiper and payment methods (sorry!) Could we please discuss this?
| - If the Accounting app is installed, the :guilabel:`Outstanding Account` and | ||
| :guilabel:`Intermediary Account` options appear in the :guilabel:`Payment Method` form to | ||
| assign transactions to different :doc:`accounts | ||
| </applications/finance/accounting/get_started/chart_of_accounts>`. Leave the field empty to | ||
| use the company's default account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- There is no mention of intermediary accounts anywhere in the accounting doc; what is it exactly? just an account receivable used specifically for that payment method (instead of the general POS)
- I think you can only select an oustanding account if you select a journal (which makes sense because outstanding accounts are used (amongst other things) to create journal entries.
- I don't think you can always set both types of accounts; sometimes it's one or the other. Also, when can you set both actually? when would that make sense?
- I'm not sure about the Chart of accounts doc link, could ther ebe a more useful doc link maybe? (let's talk to the accounting people about this!)
| - If the Accounting app is installed, the :guilabel:`Outstanding Account` and | |
| :guilabel:`Intermediary Account` options appear in the :guilabel:`Payment Method` form to | |
| assign transactions to different :doc:`accounts | |
| </applications/finance/accounting/get_started/chart_of_accounts>`. Leave the field empty to | |
| use the company's default account. | |
| - If the Accounting app is installed, the :guilabel:`Outstanding Account` (if a :guilabel:`Journal` is set) and/or | |
| :guilabel:`Intermediary Account` fields can be used to record the transactions made with the payment method in different :doc:`accounts <change this link?s>`. Leave the fields empty to use the company's default account. |
and where is the default account set? is this described somewhere in the pos doc?
3db7ff4 to
141b558
Compare
|
Hello @auva-odoo , The comments have been implemented, and the parts on Urban Piper as well as Intermediary/Outstanding Account have been improved. Thanks again for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, @emmi-odoo! i added a few more comments and suggestions!
task-4946924
141b558 to
700f49b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank @emmi-odoo !
@robodoo r+
task-4946924 closes #14783 Signed-off-by: Audrey Vandromme (auva) <auva@odoo.com>

task-4946924